Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

fix: change import of get-port to dynamic import for playwrite #38

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

conwayconstar
Copy link
Contributor

@conwayconstar conwayconstar commented Nov 2, 2023

As playwrite imports CJS in global setup it will throw the error Error: require() of ES Module changed import to dynamic import.


PR-Codex overview

Detailed summary

  • Removed the import of getPort from "get-port"
  • Updated the port property to use import("get-port").default instead of getPort()

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 88da508

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@viem/anvil Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

commit-lint bot commented Nov 2, 2023

Bug Fixes

  • change import of get-port to dynamic import for playwrite (fcd8771)

Chore

Contributors

conwayconstar

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@conwayconstar
Copy link
Contributor Author

Any update on this, its looking for an ENV var thats not present?

@fubhy fubhy merged commit ad686bd into wevm:main Dec 14, 2023
6 of 7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants