feat: add gas parameter to transaction response
#286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
FWIW, I think that specifying gas is a distraction as wallets fill it in anyway. Adding it in might convince consumers to do extra work to calculate the gas beforehand which will affect perf. |
let's not merge this PR until we receive some explanation on that being added to frame spec then. |
tmm
reviewed
Apr 28, 2024
Merged
dalechyn
added a commit
that referenced
this pull request
May 2, 2024
* feat: add `gas` parameter to transaction response * chore: changesets * Update src/types/transaction.ts * Update frog-transaction-response.mdx --------- Co-authored-by: awkweb <tom@meagher.co> Co-authored-by: jxom <jakemoxey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See more.
this is not covered in docs but is supported.