This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
feat(connectors): add fordefi detection #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 069fb05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 9, 2023
jxom
reviewed
Jul 10, 2023
jxom
reviewed
Jul 10, 2023
jxom
reviewed
Jul 10, 2023
|
@jxom thanks, fixed comments |
tmm
suggested changes
Jul 13, 2023
packages/connectors/src/metaMask.ts
Outdated
| @@ -62,6 +62,7 @@ export class MetaMaskConnector extends InjectedConnector { | |||
| if (ethereum.isTokenPocket) return | |||
| if (ethereum.isTokenary) return | |||
| if (ethereum.isZerion) return | |||
| if (ethereum.isFordefi) return | |||
There was a problem hiding this comment.
Does Fordefi override MetaMask? If not, then this is not needed.
|
@tmm thanks! pushed fixes |
jxom
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new feature to the repository by adding detection capabilities for Fordefi Wallet.
See request for adding the connector here
Additional Information
Rony Fragin
Extension Owner
Fordefi