Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

feat(connectors): add fordefi detection #417

Merged
merged 5 commits into from
Jul 24, 2023
Merged

feat(connectors): add fordefi detection #417

merged 5 commits into from
Jul 24, 2023

Conversation

rony-arnac
Copy link
Contributor

@rony-arnac rony-arnac commented Jul 9, 2023

Description

This pull request introduces a new feature to the repository by adding detection capabilities for Fordefi Wallet.

See request for adding the connector here

Additional Information


Rony Fragin
Extension Owner
Fordefi
FordefiLogoAuth0

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2023

🦋 Changeset detected

Latest commit: 069fb05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/connectors Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rony-arnac
Copy link
Contributor Author

@jxom thanks, fixed comments

@@ -62,6 +62,7 @@ export class MetaMaskConnector extends InjectedConnector {
if (ethereum.isTokenPocket) return
if (ethereum.isTokenary) return
if (ethereum.isZerion) return
if (ethereum.isFordefi) return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Fordefi override MetaMask? If not, then this is not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does

.changeset/wise-pens-brake.md Outdated Show resolved Hide resolved
packages/connectors/src/utils/getInjectedName.ts Outdated Show resolved Hide resolved
packages/connectors/src/utils/getInjectedName.test.ts Outdated Show resolved Hide resolved
@rony-arnac
Copy link
Contributor Author

@tmm thanks! pushed fixes

@rony-arnac
Copy link
Contributor Author

@tmm @jxom any other comments?

@jxom jxom merged commit e089d7d into wevm:main Jul 24, 2023
5 of 6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants