Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental writeContracts does not use client#sendCalls #2340

Closed
1 task done
BerkliumBirb opened this issue May 30, 2024 · 2 comments
Closed
1 task done

Experimental writeContracts does not use client#sendCalls #2340

BerkliumBirb opened this issue May 30, 2024 · 2 comments

Comments

@BerkliumBirb
Copy link

Check existing issues

Viem Version

2.10.11

Current Behavior

sendCalls is used directly without checking if client actually implements it.

Expected Behavior

It's expected to use getAction(client, sendCalls, 'sendCalls') instead to enable consumers implement their custom sendCalls.

Steps To Reproduce

No response

Link to Minimal Reproducible Example

No response

Anything else?

No response

@jxom
Copy link
Member

jxom commented May 30, 2024

Good idea!

@jxom jxom closed this as completed in b6fd573 May 30, 2024
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants