Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ripemd160 & sha256 #1589

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: add ripemd160 & sha256 #1589

merged 1 commit into from
Dec 14, 2023

Conversation

jxom
Copy link
Member

@jxom jxom commented Dec 14, 2023

Fixes #1581

PR-Codex overview

Focus of this PR:

This PR adds the sha256 and ripemd160 hashing functions to the codebase and updates the documentation and tests accordingly.

Detailed summary:

  • Added sha256 and ripemd160 hashing functions to the codebase.
  • Updated documentation for ripemd160 and sha256 functions.
  • Added tests for sha256 and ripemd160 functions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: 82fac1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Dec 14, 2023 8:31am

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 60.57 KB (+1.63% 🔺) 1.3 s (+1.63% 🔺) 190 ms (+199.77% 🔺) 1.5 s
viem (cjs) 79.62 KB (+1.17% 🔺) 1.6 s (+1.17% 🔺) 269 ms (+19.7% 🔺) 1.9 s
viem (minimal surface - tree-shaking) 3.9 KB (0%) 78 ms (0%) 19 ms (-52.43% 🔽) 97 ms
viem/accounts 89.9 KB (0%) 1.8 s (0%) 104 ms (-2.09% 🔽) 2 s
viem/accounts (tree-shaking) 19.54 KB (0%) 391 ms (0%) 33 ms (-13.37% 🔽) 424 ms
viem/actions 44.78 KB (0%) 896 ms (0%) 154 ms (+181.79% 🔺) 1.1 s
viem/actions (tree-shaking) 348 B (0%) 10 ms (0%) 18 ms (-42.59% 🔽) 28 ms
viem/chains 20.24 KB (0%) 405 ms (0%) 45 ms (-0.95% 🔽) 449 ms
viem/chains (tree-shaking) 473 B (0%) 10 ms (0%) 15 ms (+38.49% 🔺) 25 ms
viem/chains/utils 9.29 KB (0%) 186 ms (0%) 32 ms (-34.63% 🔽) 218 ms
viem/chains/utils (tree-shaking) 5.39 KB (0%) 108 ms (0%) 34 ms (+82.64% 🔺) 141 ms
viem/ens 44.78 KB (0%) 896 ms (0%) 27 ms (-38.7% 🔽) 923 ms
viem/ens (tree-shaking) 18.71 KB (0%) 375 ms (0%) 63 ms (+57.89% 🔺) 437 ms

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f54c87) 99.83% compared to head (82fac1a) 99.83%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1589    +/-   ##
========================================
  Coverage   99.83%   99.83%            
========================================
  Files         426      428     +2     
  Lines       36782    36942   +160     
  Branches     2140     2164    +24     
========================================
+ Hits        36721    36881   +160     
- Misses         56       57     +1     
+ Partials        5        4     -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom merged commit 69cf2d0 into main Dec 14, 2023
25 of 26 checks passed
@jxom jxom deleted the jxom/add-ripemd160-sha256 branch December 14, 2023 19:19
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant