Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multicall3 contract to Base Sepolia Chain definition #1684

Merged
merged 10 commits into from
Jan 15, 2024

Conversation

Yuripetusko
Copy link
Sponsor Contributor

@Yuripetusko Yuripetusko commented Jan 13, 2024

Multicall3 on Base Sepolia - https://base-sepolia.blockscout.com/address/0xcA11bde05977b3631167028862bE2a173976CA11?tab=contract

I checked and Bytecode matches


PR-Codex overview

This PR focuses on adding Multicall3 config to the Base Sepolia chain definition.

Detailed summary

  • Added Multicall3 config to Base Sepolia chain definition

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: 06a983c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 13, 2024

@Yuripetusko is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

Fixes this error

```
Error [ERR_REQUIRE_ESM]: require() of ES Module /Users/yuri/Sites/polkadot/viem/node_modules/is-plain-obj/index.js from /Users/yuri/Sites/polkadot/viem/node_modules/minimist-options/index.js not supported.
Instead change the require of /Users/yuri/Sites/polkadot/viem/node_modules/is-plain-obj/index.js in /Users/yuri/Sites/polkadot/viem/node_modules/minimist-options/index.js to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/minimist-options/index.js:3:23)
    at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/meow/index.js:3:28)
    at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/@changesets/cli/dist/cli.cjs.dev.js:3:12)
    at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/@changesets/cli/dist/cli.cjs.js:6:20)
    at Object.<anonymous> (/Users/yuri/Sites/polkadot/viem/node_modules/@changesets/cli/bin.js:4:1) {
  code: 'ERR_REQUIRE_ESM'
}
```
.gitignore Outdated Show resolved Hide resolved
bun.lockb Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@Yuripetusko Yuripetusko requested a review from jxom January 15, 2024 08:59
Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a patch changeset with bun changeset, then should be good to go.

@Yuripetusko Yuripetusko requested a review from tmm January 15, 2024 20:34
.changeset/metal-swans-itch.md Outdated Show resolved Hide resolved
@tmm tmm merged commit 06a28dd into wevm:main Jan 15, 2024
2 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
@mihoward21
Copy link
Contributor

any chance this can get patched into v1? not sure i can upgrade to v2 just yet, but would love to get base sepolia added to my app (and i need multicall)

@jxom
Copy link
Member

jxom commented Jan 28, 2024

@mihoward21 – you can just spread it directly onto the chain object for now until you chose migrate.

// TODO: Remove this once I upgrade to Viem v2.
const chain = {
  ...baseSepolia,
  contracts: {
    ...baseSepolia.contracts,
    multicall3: {
      address: '0xca11bde05977b3631167028862be2a173976ca11',
      blockCreated: 1059647,
    },
  }
} as const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants