Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: contractDeploy action for zkSync #1907

Merged

Conversation

mpopovac-txfusion
Copy link
Contributor

@mpopovac-txfusion mpopovac-txfusion commented Mar 5, 2024

Overview

This PR focuses on adding contractDeploy action for zkSync and using EIP712 transaction for contract deployments. Also it fixes issues related to the factoryDeps formatter and populating eip712 transaction.

Detailed summary

  • Added contractDeploy action
  • Added encoding deploy data on zkSync
  • Added hashing of the bytecode on zkSync
  • Fixed factoryDeps field formatter
  • Fixed factoryDeps field when calling getEip712Domain
  • Fixed paymasterInput default value
  • Updated sidebar links for zkSync
  • Added new page for deployContract action

PR-Codex overview

This PR adds a new deployContract action to zkSync Extensions.

Detailed summary

  • Added deployContract action to zkSync Extensions
  • Defined constants for account abstraction versions and contract addresses
  • Implemented error handling for bytecode length and words
  • Updated formatters and utilities for contract deployment
  • Added test cases for bytecode hashing and contract deployment
  • Updated documentation for deployContract action

The following files were skipped due to too many changes: src/chains/zksync/decorators/eip712.ts, src/chains/zksync/utils/abi/encodeDeployData.ts, src/chains/zksync/actions/deployContract.ts, src/chains/zksync/constants/abis.ts, site/pages/zksync/actions/deployContract.md, src/chains/zksync/utils/abi/encodeDeployData.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 5, 2024

Someone is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 5118dfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dutterbutter
Copy link
Contributor

Relevant to resolve: #1887

@jxom jxom force-pushed the zksync-enable-deployment-of-contracts branch from 1595f9c to feb6681 Compare March 24, 2024 20:17
@jxom jxom merged commit b40210f into wevm:main Mar 24, 2024
5 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Mar 24, 2024
@tmm tmm mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants