Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EIP-5792 #2053

Merged
merged 8 commits into from
Apr 2, 2024
Merged

feat: EIP-5792 #2053

merged 8 commits into from
Apr 2, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Apr 2, 2024

Adding experimental support for bleeding-edge wallet JSON-RPC APIs.


PR-Codex overview

This PR adds experimental support for EIP-5792 wallet_ methods, including getCapabilities, sendCalls, and getCallsStatus.

Detailed summary

  • Added support for EIP-5792 wallet_ methods in experimental package
  • Updated package.json to include module paths
  • Added functions for getCapabilities, sendCalls, and getCallsStatus
  • Defined types for wallet capabilities and calls status
  • Updated test files for the new functions

The following files were skipped due to too many changes: src/types/eip1193.ts, src/experimental/actions/sendCalls.ts, src/experimental/actions/getCallsStatus.test.ts, src/experimental/decorators/eip5792.ts, src/experimental/actions/sendCalls.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 85a7326

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Apr 2, 2024 8:33pm

Copy link
Contributor

github-actions bot commented Apr 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 66.47 KB (0%) 1.4 s (0%) 264 ms (+98.24% 🔺) 1.6 s
viem (cjs) 86.33 KB (0%) 1.8 s (0%) 209 ms (+74.67% 🔺) 2 s
viem (minimal surface - tree-shaking) 3.76 KB (0%) 76 ms (0%) 3 ms (+81.31% 🔺) 79 ms
viem/accounts 91.48 KB (0%) 1.9 s (0%) 88 ms (+80.92% 🔺) 2 s
viem/accounts (tree-shaking) 21.1 KB (0%) 423 ms (0%) 28 ms (+32.41% 🔺) 450 ms
viem/actions 46.68 KB (0%) 934 ms (0%) 53 ms (-2.55% 🔽) 987 ms
viem/actions (tree-shaking) 340 B (0%) 10 ms (0%) 1 ms (-80.07% 🔽) 11 ms
viem/chains 30.94 KB (0%) 619 ms (0%) 104 ms (+376.81% 🔺) 723 ms
viem/chains (tree-shaking) 367 B (0%) 10 ms (0%) 1 ms (+56.39% 🔺) 11 ms
viem/chains/utils 1.16 KB (0%) 24 ms (0%) 4 ms (+311.79% 🔺) 27 ms
viem/ens 46.68 KB (0%) 934 ms (0%) 46 ms (+187.27% 🔺) 980 ms
viem/ens (tree-shaking) 20.7 KB (0%) 414 ms (0%) 33 ms (+147.06% 🔺) 446 ms

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (6d8cde2) to head (f437110).
Report is 6 commits behind head on main.

❗ Current head f437110 differs from pull request most recent head 85a7326. Consider uploading reports for the commit 85a7326 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2053      +/-   ##
==========================================
- Coverage   99.72%   92.87%   -6.85%     
==========================================
  Files         599      569      -30     
  Lines       54151    49592    -4559     
  Branches     2611     1864     -747     
==========================================
- Hits        54003    46061    -7942     
- Misses        133     3488    +3355     
- Partials       15       43      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom marked this pull request as ready for review April 2, 2024 20:21
@jxom jxom changed the title wip: EIP-5792 feat: EIP-5792 Apr 2, 2024
@jxom jxom merged commit e53fe12 into main Apr 2, 2024
2 of 3 checks passed
@jxom jxom deleted the eip5792 branch April 2, 2024 20:26
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
@jessepollak
Copy link

Love seeing this - epic.

@imaksp
Copy link

imaksp commented Apr 3, 2024

Good to see but here it shows Stagnant state for this & it says should not be used, does any wallet app supports this:
https://eips.ethereum.org/EIPS/eip-5792

@jxom
Copy link
Member Author

jxom commented Apr 3, 2024

Thanks for raising! We (Coinbase Wallet + Viem) are working on picking this EIP up again. :)

ethereum/EIPs#8361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants