Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decodeEventLog bug fixed: named args with a missing name #2092

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

ITZSHOAIB
Copy link
Contributor

@ITZSHOAIB ITZSHOAIB commented Apr 7, 2024

Issue: #2081

Description:
If an ABI event parameter name is undefined or is an empty string (""), decodeEventLog seems to partially decode it. This happens even if the number of indexed/non-indexed parameters in the ABI item matches the log data/topics, regardless of the strict option.

Fix:
decodeEventLog will return the arguments as an array, ordered the same way as the ABI parameters, omitting all argument names but still decoding all arguments properly.


PR-Codex overview

This PR fixes the decoding of event logs when an event argument is missing a name.

Detailed summary

  • Fixed decoding of event logs with missing argument names
  • Adjusted handling of unnamed event arguments in decoding logic

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Apr 7, 2024

@ITZSHOAIB is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Apr 7, 2024

🦋 Changeset detected

Latest commit: 77d0f1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom merged commit 25cd1a2 into wevm:main Apr 7, 2024
12 of 20 checks passed
@github-actions github-actions bot mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants