decodeEventLog bug fixed: named args with a missing name #2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2081
Description:
If an ABI event parameter name is undefined or is an empty string (""), decodeEventLog seems to partially decode it. This happens even if the number of indexed/non-indexed parameters in the ABI item matches the log data/topics, regardless of the strict option.
Fix:
decodeEventLog will return the arguments as an array, ordered the same way as the ABI parameters, omitting all argument names but still decoding all arguments properly.
PR-Codex overview
This PR fixes the decoding of event logs when an event argument is missing a name.
Detailed summary