Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default fee values for zksync eip712 transactions #2168

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

kiriyaga-txfusion
Copy link
Contributor

@kiriyaga-txfusion kiriyaga-txfusion commented Apr 22, 2024

Overview
This PR focuses on fixing default values for eip712 transactions

Detailed summary

  • Added gasPerPubdataDefault constant
  • Updated prepareTransactionRequest action to include fees
  • Functions now use gasPerPubdataDefault as default value for gas per pubdata if is not provided

PR-Codex overview

This PR fixes default fee values for zkSync EIP712 transactions by updating gas per pubdata values and adjusting transaction parameters.

Detailed summary

  • Updated default gasPerPubdata value to 50000n
  • Added fees to transaction parameters
  • Adjusted condition for EIP-1559 fees
  • Updated gasPerPubdataByteLimit to use gasPerPubdataDefault
  • Updated gasPerPubdata value in formatters and serializers

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 1997c0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

@kiriyaga is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

@kiriyaga-txfusion kiriyaga-txfusion changed the title fix: add default values for fees for zksync eip712 transactions fix: default values for fees for zksync eip712 transactions Apr 22, 2024
@kiriyaga-txfusion kiriyaga-txfusion changed the title fix: default values for fees for zksync eip712 transactions fix: default fee values for zksync eip712 transactions Apr 22, 2024
@jxom
Copy link
Member

jxom commented Apr 23, 2024

Hi. Can I please have write access to this fork?

@kiriyaga-txfusion
Copy link
Contributor Author

Hi @jxom, you are invited with a write access.

@jxom jxom force-pushed the kiriyaga-txfusion-optionals-fee branch from 941a844 to 19a0fcb Compare April 23, 2024 22:43
@jxom jxom merged commit 1c550fa into wevm:main Apr 23, 2024
2 of 3 checks passed
@jxom jxom deleted the kiriyaga-txfusion-optionals-fee branch April 23, 2024 22:45
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants