fix: merge fetchOptions from HttpRpcClient options with request-specific options #2193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating proxies in viem as per the recent fix, I noticed that the implementation was only considering request-specific
fetchOptions
and skipping those passed to the HTTP transportThis PR fixes it by merging the
fetchOptions
from theHttpRpcClient
options with those from individual requestsFor anyone facing this issue, you can use a temporary fix until the PR is merged:
"postinstall": "patch-package"
node_modues/viem
and go to folder that corresponds to module systems currently being used (_esm, _cjs)getHttpRpcClient
function fromutils/rpc/http.js
: add...(options.fetchOptions || {}),
at the first line ofconst init = {
object.npx patch-package viem
PR-Codex overview
This PR fixes the declaration of
fetchOptions
on HTTP RPC.Detailed summary
fetchOptions
declaration on HTTP RPC inhttp.ts
fetchOptions
object merging logic to include bothoptions
andparams
properties.