New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: legacy transaction address recovery #2195
Conversation
🦋 Changeset detectedLatest commit: 62f140c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
==========================================
+ Coverage 97.69% 99.72% +2.03%
==========================================
Files 623 629 +6
Lines 55446 56198 +752
Branches 2445 2681 +236
==========================================
+ Hits 54166 56046 +1880
+ Misses 1260 139 -1121
+ Partials 20 13 -7 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
Resolves #2191.
Added support for legacy transaction address recovery + support legacy signature format in
signatureToHex
.PR-Codex overview
This PR fixes legacy transaction address recovery by updating the
yParity
value in various transaction-related files.Detailed summary
yParity
value calculation based onv
inparseTransaction.ts
yParity
values inserializeTransaction.test.ts
andparseTransaction.test.ts
yParity
handling insignatureToHex.ts
and related tests