Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-6492 sig utils #2209

Merged
merged 4 commits into from
May 6, 2024
Merged

ERC-6492 sig utils #2209

merged 4 commits into from
May 6, 2024

Conversation

wilsoncusack
Copy link
Contributor

@wilsoncusack wilsoncusack commented May 2, 2024

Utils here are intended to help apps parse signature in the post ERC-6492 world. For offchain verification, Viem's verifyMessage is great. But for onchain, apps will need to parse out just the signed data to use for the ERC-1271 call onchain.


PR-Codex overview

This PR introduces ERC-6492 signature utilities, deprecates old signature functions, updates signature handling across multiple files, and improves documentation.

Detailed summary

  • Added ERC-6492 signature utilities: isErc6492Signature, parseErc6492Signature, serializeErc6492Signature
  • Deprecated old signature functions
  • Updated signature handling in various files
  • Improved documentation for serializeSignature function

The following files were skipped due to too many changes: src/utils/signature/recoverTransactionAddress.test.ts, site/pages/docs/utilities/hexToSignature.md, site/pages/docs/utilities/compactSignatureToHex.md, site/pages/docs/utilities/hexToCompactSignature.md, src/utils/signature/hexToSignature.ts, src/actions/public/verifyHash.test.ts, src/utils/signature/serializeErc6492Signature.test.ts, src/utils/signature/compactSignatureToHex.ts, site/pages/docs/utilities/isErc6492Signature.md, src/utils/signature/signatureToHex.test.ts, src/utils/signature/parseERC6492Signature.test.ts, site/sidebar.ts, src/utils/signature/signatureToHex.ts, src/utils/signature/hexToCompactSignature.ts, src/utils/signature/recoverAddress.test.ts, site/pages/docs/utilities/parseErc6492Signature.md, site/pages/docs/utilities/serializeErc6492Signature.md, src/utils/signature/serializeErc6492Signature.ts, src/utils/signature/recoverPublicKey.test.ts, src/utils/signature/hexToSignature.test.ts, src/utils/signature/parseERC6492Signature.ts, src/index.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 395a291

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 2, 2024

@wilsoncusack is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit 76a92bb into wevm:main May 6, 2024
3 of 20 checks passed
@github-actions github-actions bot mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants