Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENS exports packetToBytes and parseAvatarRecord #2214

Merged
merged 3 commits into from May 4, 2024
Merged

Conversation

wottpal
Copy link
Contributor

@wottpal wottpal commented May 3, 2024

  • Add new exports packetToBytes and parseAvatarRecord
  • Slightly improved comments of packetToBytes and parseAvatarRecord
  • Added root export (src/index.ts) for normalize which was missing (don't know if this was intended)
  • Changeset

@jxom @tmm Also happy to add related documentation pages, but had the feeling it's good as it is as they are quite niche functions and have an already well documented behavior within the ENS docs (which are linked). :)


PR-Codex overview

This PR focuses on exporting ENS-related utility functions packetToBytes and parseAvatarRecord.

Detailed summary

  • Exported packetToBytes and parseAvatarRecord utility functions for ENS-related operations.
  • Added packetToBytes function to encode a DNS packet into a ByteArray.
  • Added parseAvatarRecord function to parse an ENS avatar record.
  • Updated exports in index.ts to include the new utility functions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 3, 2024

🦋 Changeset detected

Latest commit: 8f2dcdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 3, 2024

@wottpal is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jxom jxom merged commit a436499 into wevm:main May 4, 2024
6 of 20 checks passed
@github-actions github-actions bot mentioned this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants