Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong ABNF Message construction #2337

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

jaeil-wiki
Copy link
Contributor

@jaeil-wiki jaeil-wiki commented May 29, 2024

fix wrong ABNF message format construction on createSiweMessage in src/utils/siwe/createSiweMessage.ts.

  • The Issue is missing LF between prefix and suffix when constructing without statement argument.
    refs: https://eips.ethereum.org/EIPS/eip-4361
  • Please consider prefixRegex in parseSiweMessage.ts:L50 pattern is still correct. (It looks good to me 🤔 )

PR-Codex overview

This PR updates the createSiweMessage function to improve the message format and adds missing newline characters for better readability.

Detailed summary

  • Updated createSiweMessage statement construction to match ABNF Message Format
  • Added missing newline character in prefix for better message formatting

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 319f0db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 29, 2024

@jaeil-wiki is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@jaeil-wiki jaeil-wiki changed the title fix: wrong ABNF Message construction Fix wrong ABNF Message construction May 29, 2024
.changeset/clever-shoes-hope.md Outdated Show resolved Hide resolved
@tmm tmm merged commit 8984eee into wevm:main Jun 4, 2024
11 of 25 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants