Fix wrong ABNF Message construction #2337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix wrong ABNF message format construction on
createSiweMessage
insrc/utils/siwe/createSiweMessage.ts
.LF
between prefix and suffix when constructing withoutstatement
argument.refs: https://eips.ethereum.org/EIPS/eip-4361
prefixRegex
inparseSiweMessage.ts:L50
pattern is still correct. (It looks good to me 🤔 )PR-Codex overview
This PR updates the
createSiweMessage
function to improve the message format and adds missing newline characters for better readability.Detailed summary
createSiweMessage
statement construction to match ABNF Message Formatprefix
for better message formatting