Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: generated.ts file from adding wagmi actions is broken on wagmi-core #1945

Closed
1 task done
d1onys1us opened this issue Mar 4, 2023 · 4 comments
Closed
1 task done

Comments

@d1onys1us
Copy link

d1onys1us commented Mar 4, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Package Version

^0.9.7 (wagmi-core)

Current Behavior

I added actions to wagmi.config.ts and the generated output file imports:

  • GetContractArgs
  • ReadContractConfig
  • WriteContractMode
  • WriteContractArgs
  • WriteContractPreparedArgs
  • WriteContractUnpreparedArgs
  • PrepareWriteContractConfig

with errors.

Expected Behavior

i should be able to use wagmi actions in my wagmi-core project generated from wagmi-cli

Steps To Reproduce

after adding actions here it broke: https://github.com/d1onys1us/dapp-slaps/blob/main/packages/app/wagmi.config.ts (commented here, but if uncommented and try to use the actions it won't work)

Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)

https://github.com/d1onys1us/dapp-slaps/blob/main/packages/app/wagmi.config.ts

Anything else?

image

@wslyvh
Copy link
Contributor

wslyvh commented Mar 7, 2023

I had the same with wagmi version 0.10.0.
I was trying to create a reproducible example, but the latest version (currently 0.12.1) solved it for me.

Hope that helps!

Here's the repo I was preparing
https://github.com/wslyvh/wagmi-cli-test

EDIT: upgrading to 0.12.0 gave me the same issues as #1964
Version 0.11.6 also solves the issues on the generated file

@jxom
Copy link
Member

jxom commented Mar 7, 2023

Can you check if this is resolved on 0.12?

If not, can you please provide a more minimal reproducible repository w/ pnpm create wagmi or alike?

Will reopen when done!

@jxom jxom closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2023
@d1onys1us
Copy link
Author

d1onys1us commented Jun 10, 2023

confirming this is still an issue on:
"@wagmi/cli": "^1.1.0",
"@wagmi/core": "^1.1.1",

@tmm
Copy link
Member

tmm commented Jun 14, 2023

@d1onys1us please open a new issue with reproduction if this is still a problem. It's hard to track people replying to old issues.

@wevm wevm locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants