-
-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: MetaMask and Brave Wallet collision #436
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@tmm why do you have this code? It seems like it's causing a lot of webcompatability issues that don't need to be there. For example we would work with https://foundation.app/feed otherwise, but this PR causes it to not be able to connect with Brave Wallet. |
@bbondy Hi there! Looks like they are using the
Sometimes developers want to target specific wallets to do things, like show icons or custom interface. With injected wallets, it's hard to isolate a specific one from the group – e.g. maybe the injected wallet is unknown to the app developer or there are multiple attached to the window (e.g. Coinbase Wallet's Happy to chat more if you have additional questions. |
thanks @tmm |
If we're API compatible with MetaMask though, what is the benefit of blocking Brave Wallet from the MetaMask option? |
To add a bit more depth to my previous message. Brave Wallet is a wallet like other wallets, but it is also an implementation of the MetaMask API. That is why we set There are a lot of Dapps out there using the MetaMask connector only. We find it is important to provide not only an alternate wallet, but an alternative implementation to the MetaMask API. This allows for Dapp usage that is built for MetaMask but for people that don't want to be locked into MetaMask's control. I have a suggestion that might be best. Allow wallets that are compatible to MetaMask to set |
@tmm could you help? ^ |
Description
window.ethereum
wrapped RPC APIAdditional Information
Your ENS/address: awkweb.eth