Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Loosen restriction on faraday #1

Merged
merged 2 commits into from Feb 20, 2018
Merged

Conversation

philsturgeon
Copy link
Contributor

If there is a dev version with a breaking change, we can downgrade the requirement, but so far its been fairly consistent

If there is a dev version with a breaking change, we can downgrade the requirement, but so far its been fairly consistent
@coveralls
Copy link

coveralls commented Feb 20, 2018

Coverage Status

Coverage remained the same at 96.97% when pulling 0af290e on feature/support-newer-faraday into 5f6ea2f on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.97% when pulling b120199 on feature/support-newer-faraday into 5f6ea2f on master.

Copy link

@bagmangood bagmangood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to not just do < 0.15 if we are this concerned about versioned behavior?

@philsturgeon philsturgeon merged commit 55c0f3c into master Feb 20, 2018
@philsturgeon
Copy link
Contributor Author

This looseness should be fine, I used to be concerned but I’m relatively confident the api will stay the same until v1.

@philsturgeon philsturgeon deleted the feature/support-newer-faraday branch February 20, 2018 18:27
Copy link

@EdwardKang EdwardKang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants