Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a saga instance is not found in the saga store do not reject the message #196

Closed
rhinof opened this issue Oct 9, 2019 · 0 comments
Closed

When a saga instance is not found in the saga store do not reject the message #196

rhinof opened this issue Oct 9, 2019 · 0 comments
Labels
bug Something isn't working
Projects
v1.2

Comments

@rhinof
Copy link
Contributor

rhinof commented Oct 9, 2019

In this case we should not return an error but rather log a Warn/Info and return nil
There are edge cases in which the instance can be nil due to completion of the saga
on a different node or worker.
In cases like these returning an error here would prevent additional handlers to be invoked
as the message will get rejected and transactions will be rolledback
@rhinof rhinof added the bug Something isn't working label Oct 9, 2019
@rhinof rhinof added this to To do in v1.2 via automation Oct 9, 2019
rhinof pushed a commit that referenced this issue Oct 9, 2019
logging a Warn instead of rejecting the message when saga not found i…
c107419 
…n store

closes #196
#196
@rhinof rhinof mentioned this issue Oct 9, 2019
Merged
rhinof pushed a commit that referenced this issue Oct 9, 2019
Saga bug fixes (#198)
a07bd80 
* fixing the way that the target service was resolved

closes #195

#195

* Fixing the value of the StartedBy field when creating a new saga
instance

closes #194
#194

* rolling back checking if replying to an event to maintain backward compatibility

* logging a Warn instead of rejecting the message when saga not found in store

closes #196
#196
@rhinof rhinof closed this as completed Oct 9, 2019
v1.2 automation moved this from To do to Done Oct 9, 2019
rhinof pushed a commit that referenced this issue Oct 20, 2019
v1.1.6 rollup (#218)
50aecfb 
* inceased outbox VARCHAR column length to 2048 (#155)

* added reply to initiator functionality to sagas (#157)

* added generic handler metrics with message type as the label (#144)

* added generic handler metrics with message type as the label

* add handler name label to the metrics

* adding new metrics to the read me

* Fix handle empty body (#156)

* set the correct Type and Content-Type headers on out going messages (#160)

* set the correct Type and Content-Type headers on out going messages

* refactoring

* fixing ReplyToInitiator not working  when initiator sends a message via the RPC interface (#163)


* fixing ReplyToInitiator not working  when initiator sends a message via the RPC interface

* Improved wording of saga documentation article (#164)

* better wording for documentation

* added golangcli lint configuration and fixed linting failures (#165)

* fixed logging issues (#167)

* allow getting the saga id of the current invoked saga (#168)

* setting the target saga id on the saga correlation id field (#171)

* support emperror (#174)

* setting the target saga id on the saga correlation id field

* added emperror support

* Fix logging and added logging documentation (#176)

* fixed logging issues and added documentation

logging via the invocation interface was broken and did not add
contextual data related to the invocation due to a bug in the way the Glogged structure is currently implemented.

Also added documentation on how logging should be done within a
handler including adding context to returned errors so that data gets logged

* added missing documentation file

* added documentation on serialization support (#177)

* fixed emperror url format

* added serialization documentation

* added documentation for messaging patterns, retries and transactional processing (#181)

* fixed emperror url format

* added serialization documentation

* added documentation for message semantics, retries and transactions

* Fix docmentation (#182)

* fixed emperror url format

* added serialization documentation

* added documentation for message semantics, retries and transactions

* fixing tx documentation page

* Added sample application (#184)

* Update README.md

* added ability to configure outbox (#186)

* fixing issues with invoking the GlobalrawMessageHandler (#189)

Fixing the following issues:

#187
#188

* Saga bug fixes (#198)

* fixing the way that the target service was resolved

closes #195

#195

* Fixing the value of the StartedBy field when creating a new saga
instance

closes #194
#194

* rolling back checking if replying to an event to maintain backward compatibility

* logging a Warn instead of rejecting the message when saga not found in store

closes #196
#196

* fixing minor tech debt issues (#199)

* v1.1.5 rollup to master (#185)

* fix(bug:200) logs are now being reported correctly

Fixes issue #200
Also updated go.mod for newer versions of dependancies

* added metrics for transactional outbox (#193)

* added metrics for transactional outbox

The follwoing metrics were added
outbox_total_records: reports the total amount of records currently in the outbox
outbox_pending_delivery: reports the total amount of records pending delivery currently in the outbox
outbox_pending_removal: reports the total amount of records that were sent and pending removal currently in the outbox

* reading status and count fields in the correct order from rows

* service name now gets added to log entries when a custom logger is set or in saga store (#204)

* service name now gets added to log entries when a custom logger is set

#200

* fixing issue that the saga store was not adding the service to its log
entires

#206

* Fix logging (#207)

* service name now gets added to log entries when a custom logger is set

#200

* fixing issue that the saga store was not adding the service to its log
entires

#206

* fixing minor issue with logging saga store initialization

* Add support for setting the idempotency key on a BusMessage (#208)

* Added x-idempotency-key header and the ability for client code to set it

#106

* Set the value of BusMessage.ID as the default value of BusMessage.IdempotencyKey

* fixing issue with txoutbox failing to deliver a message after 50 (#205)

failed attempts

#203

* Allow correctly replaying Events (#190)

* refactored returnDeadToQueue to allow correctly returning Events as well as Messages(commands)

* fixed lint issues

* code review fixes

* more review comments

* minor change to force coveralls to rebuild

* returnDeadToQueue - changed routing-key to always be that routing-key of the first death, not the latest death, also refactored naming and added comment for clarity

* moved getRoutingParamsFromDelivery to worker.go

* fixed type in migration name attribute (#213)

* adding all logging context data to worker and saga log entries (#215)

* adding all logging context data to worker and saga log entries

* added logging with context when command or reply received for saga def but no saga correlation id found

* removing minor discrepancies and updating documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
v1.2
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhinof