Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint fixes into master #154

Merged
merged 30 commits into from
Sep 1, 2019
Merged

golint fixes into master #154

merged 30 commits into from
Sep 1, 2019

Commits on Jul 22, 2019

  1. add handler metrics to bus and saga (#101)

    * add handler metrics to bus and saga + tests
    
    * fix build
    
    * add 0 to the default buckets to catch fast message handling
    
    * PR correction - changed latency to summary(removed bucket configuration), add registration for saga handlers
    
    * PR correction - getting logger as a param
    
    * PR correction - new line in eof
    
    * PR corrections message handler + sync.map + latency as summary
    
    * add rejected messages metric
    danielwitz authored and Guy Baron committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    f617e04 View commit details
    Browse the repository at this point in the history
  2. dead letter handler should reject messages on failures and rollbacks …

    …and ack on commit success (#105)
    
    * dead letter handler should reject messages on failures and rollbacks
    
    * dead letter handler should reject messages on failures and rollbacks
    
    * dead letter handler should reject messages on failures and rollbacks
    
    * dead letter handler should reject messages on failures and rollbacks
    adiweiss authored and Guy Baron committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    00177c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2019

  1. return an error from the saga store when deleting a saga if saga can …

    …not (#110)
    
    be found
    
    In order to deal with concurrent deletes of the sage saga instance we
    would wan't to indicate that deleting the saga failed if the saga is not
    stored so callers can take proper action
    Guy Baron committed Aug 4, 2019
    Configuration menu
    Copy the full SHA
    403cd5e View commit details
    Browse the repository at this point in the history
  2. Persisted timeouts (#107)

    * decouple transaction manager from glue
    
    * moved timeout manager to gbus/tx package
    
    * initial commit in order to support persisted timeouts
    
    * first working version of a mysql persisted timeout manager
    
    * fixing ci lint errors
    
    * refactored ensure schema of timeout manager
    
    * cleanup timeout manager when bs shuts down
    
    * fixing formatting issues
    
    * changed logging level from Info to Debug when inserting a new timeout
    
    * resusing timeouts tablename (PR review)
    
    * renamed AcceptTimeoutFunction to SetTimeoutFunction on the
    TimeoutManager interface (PR review)
    
    * refactored glue to implement the Logged inetrface and use the GLogged
    helper struct
    
    * locking timeout record before executing timeout
    
    In order to prevent having a timeout beeing executed twice due to two
    concurrent grabbit instances running the same service a lock (FOR
    UPDATE) has been placed on the timeout record  in the scope of the executing transaction
    
    * Commiting the select transaction when querying for pending timeouts
    
    * feat(timeout:lock): This is done in order to reduce contention and allow for parallel processing in case of multiple grabbit instances
    Guy Baron committed Aug 4, 2019
    Configuration menu
    Copy the full SHA
    d84bc71 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Enable returning a message back from the dead to the queue (#112)

    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * enable sending raw messages
    
    * return to q
    
    * return to q
    
    * return to q
    
    * return to q
    
    * return dead to q
    
    * allow no retries
    
    * test - resend dead to queue
    
    * test - resend dead to queue
    
    * test - resend dead to queue
    
    * test - resend dead to queue - fixes after cr
    
    * test - resend dead to queue - fixes after cr
    
    * test - resend dead to queue - fixes after cr
    adiweiss authored and Guy Baron committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    858d962 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. added metric report on saga timeout (#114)

    1) added reporting saga timeouts to the glue component
    2) fixed mysql timeoutmanager error when trying to clear a timeout
    Guy Baron committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    2b4ea92 View commit details
    Browse the repository at this point in the history
  2. Added documentation for grabbit metrics (#117)

    * added initial documentation for grabbit metrics
    
    *  including metrics section in readme.md
    Guy Baron committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    459fd66 View commit details
    Browse the repository at this point in the history
  3. fixing goreportcard issues (#118)

    Guy Baron committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    e80bb49 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc0a331 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2019

  1. corrected saga metrics name and added to metrics documentation (#119)

    * corrected saga metrics name and added documentatio
    
    * corrected saga metric name
    
    * corrected typos
    Guy Baron committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    de202b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. removed non transactional bus mode (#120)

    Guy Baron committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    5b6de51 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. remove fields

    adi.yaskolka committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    d4170d6 View commit details
    Browse the repository at this point in the history
  2. remove fields

    adi.yaskolka committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    65aaf60 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #123 from wework/fix_logs_structure

    remove fields
    adiweiss committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    82eb197 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. go fmt and go lint error fixes to improve goreportcard (#126)

    * go fmt on some files
    
    * go fmt
    
    * added comments on exported types
    Guy Baron committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    d5d04b9 View commit details
    Browse the repository at this point in the history
  2. cunsume the messages channel via ranging over the channel to prevent (#…

    …125)
    
    empty delivreies
    Guy Baron committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    2b91211 View commit details
    Browse the repository at this point in the history
  3. Migrations functionality (#111)

    * implement migrations
    
    * implement migrations
    
    * implement migrations
    
    * implement migrations
    
    * implement migrations
    
    * migrations
    
    * migrations
    
    * migrations
    
    * migrations
    
    * migrations
    
    * migrations
    
    * migrations
    
    * fix tests error
    
    * add migrations
    
    * migrations - timeout table migration
    
    * test - resend dead to queue - fixes after cr
    
    * migraration to grabbit (use forked migrator)
    
    * remove fields
    
    * remove fields
    
    * remove fields
    
    * remove fields
    adiweiss authored and Guy Baron committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    4337e55 View commit details
    Browse the repository at this point in the history
  4. sanitize migrations table name (#130)

    adiweiss authored and Guy Baron committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    4c1c812 View commit details
    Browse the repository at this point in the history
  5. more linting fixes for goreportcard (#129)

    Guy Baron committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    6c2a9e6 View commit details
    Browse the repository at this point in the history
  6. added metrics on deadLetterHandler, refactored HandleDeadLetter inter… (

    #122)
    
    * added metrics on deadLetterHandler, refactored HandleDeadLetter interface to receive new DeadLetterMessageHandler type
    
    * fix dead letter test and a build error
    
    * added documentation for DeadLetterMessageHandler, also fixed poison spelling throughout code
    
    * retrigger build
    yuvmendel authored and Guy Baron committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    58b7cec View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. Configuration menu
    Copy the full SHA
    a916269 View commit details
    Browse the repository at this point in the history
  2. Improved tracing and added documentation (#142)

    Guy Baron committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    b4d07df View commit details
    Browse the repository at this point in the history
  3. Support handling raw message (#138)

    Guy Baron committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    488c31a View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Configuration menu
    Copy the full SHA
    ae08ff0 View commit details
    Browse the repository at this point in the history
  2. bug fix - when a deadletterhandler panics grabbit fails to reject the… (

    #136)
    
    * bug fix - when a deadletterhandler panics grabbit fails to reject the message
    
    * bug fix - when a deadletterhandler panics grabbit fails to reject the message
    
    * BPINFRA125 - MERGE MASTER INTO BRANCH
    adiweiss authored and Guy Baron committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    4ad01a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. calling channel.Cancel when worker is stopped (#149)

    Guy Baron committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    eef69fb View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2019

  1. Handle empty body messages (#147)

    adiweiss authored and Guy Baron committed Aug 31, 2019
    Configuration menu
    Copy the full SHA
    e1ac9dc View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2019

  1. fixing golint warnings from goreport card (#150)

    Guy Baron committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    2c0a897 View commit details
    Browse the repository at this point in the history
  2. more golint fixes (#152)

    Guy Baron committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    fa87818 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into v1.x

    Guy Baron committed Sep 1, 2019
    Configuration menu
    Copy the full SHA
    b54e818 View commit details
    Browse the repository at this point in the history