Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing issue with txoutbox failing to deliver a message after 50 attempts #205

Merged
merged 2 commits into from
Oct 16, 2019
Merged

fixing issue with txoutbox failing to deliver a message after 50 attempts #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d7841
fixing issue with txoutbox failing to deliver a message after 50
Oct 13, 2019
7d21ad9
Merge branch 'v1.x' into fix-outbox
Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions gbus/tx/mysql/txoutbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,11 @@ const (
)

var (
maxPageSize = 500
maxDeliveryAttempts = 50
sendInterval = time.Second
scavengeInterval = time.Second * 60
metricsInterval = time.Second * 15
ackers = 10
maxPageSize = 500
sendInterval = time.Second
scavengeInterval = time.Second * 60
metricsInterval = time.Second * 15
ackers = 10
)

//TxOutbox is a mysql based transactional outbox
Expand Down Expand Up @@ -288,7 +287,7 @@ func (outbox *TxOutbox) updateAckedRecord(deliveryTag uint64) error {
}

func (outbox *TxOutbox) getMessageRecords(tx *sql.Tx) (*sql.Rows, error) {
selectSQL := "SELECT rec_id, exchange, routing_key, publishing FROM " + getOutboxName(outbox.svcName) + " USE INDEX (status_delivery) WHERE status = " + strconv.Itoa(Pending) + " AND delivery_attempts < " + strconv.Itoa(maxDeliveryAttempts) + " ORDER BY rec_id ASC LIMIT " + strconv.Itoa(maxPageSize) + " FOR UPDATE SKIP LOCKED"
selectSQL := "SELECT rec_id, exchange, routing_key, publishing FROM " + getOutboxName(outbox.svcName) + " USE INDEX (status_delivery) WHERE status = " + strconv.Itoa(Pending) + " ORDER BY rec_id ASC LIMIT " + strconv.Itoa(maxPageSize) + " FOR UPDATE SKIP LOCKED"
return tx.Query(selectSQL)
}

Expand Down