Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(ray-product):Added Type in tsx format #248

Closed
wants to merge 9 commits into from

Conversation

jamesdamild
Copy link
Contributor

@jamesdamild jamesdamild commented Oct 29, 2019

Type component

How to run locally
$ yarn storybook
$ yarn test product-react --watch

Nutshell Details:
Semantic wrapper around Type element:
2019-10-29 15 01 55

);
});

test('should renders type wshouldh a style', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit* lol

Copy link
Contributor

@Morgantheplant Morgantheplant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I think the component name could be improved. Type sounds like an enum and not a component.

@jamesdamild
Copy link
Contributor Author

@Morgantheplant any recommendation for the name? I don't like the name either

@Morgantheplant
Copy link
Contributor

@Morgantheplant any recommendation for the name? I don't like the name either

I think Typography would make sense so it’s consistent with the ray docs

@jamesdamild
Copy link
Contributor Author

closing this pull request, had some problems with this branch

@jamesdamild jamesdamild deleted the james/ray-product/Type-js-to-tsx branch October 29, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants