-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(ray-product):Added Type in tsx format #248
Conversation
); | ||
}); | ||
|
||
test('should renders type wshouldh a style', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit* lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but I think the component name could be improved. Type sounds like an enum and not a component.
@Morgantheplant any recommendation for the name? I don't like the name either |
I think |
closing this pull request, had some problems with this branch |
Type component
How to run locally
$ yarn storybook
$ yarn test product-react --watch
Nutshell Details:
Semantic wrapper around Type element: