Split linting and loading #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
force-pushed
the
seperate-loader-lint
branch
3 times, most recently
from
78a3ec9
to
86ceba0
Compare
|
|
||
| context('when `' + profileName + '` profile is loaded', () => { | ||
| testProfile(profile); | ||
| context('when `' + profileName + '` profile is loaded', () => { |
There was a problem hiding this comment.
String interpolation makes this easier
`when \`${profileName}\` profile is loaded`
752d7d9
to
bca9746
Compare
philsturgeon
force-pushed
the
seperate-loader-lint
branch
3 times, most recently
from
1eca6bf
to
409ed02
Compare
philsturgeon
force-pushed
the
seperate-loader-lint
branch
from
409ed02
to
9dfca20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
This lets us write tests directly against the linter instead of having to go via rule files. We can invent theoretical rules to ensure the mechanics are happy, aaand it's helped improve coverage.