New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix args parsing #33

Merged

philsturgeon merged 1 commit into wework:master from MikeRalphson:fix-args-parsing

Mar 22, 2018

Contributor

MikeRalphson commented Mar 22, 2018

This fixes the behaviour with commanders options parsing noted in #23

The problem was that program.parse is an async method and the test for no arguments was happening synchronously.

MikeRalphson requested a review from philsturgeon

March 22, 2018 17:13

philsturgeon approved these changes

View reviewed changes

coveralls commented Mar 22, 2018 •

edited

Loading

Coverage remained the same at 63.748% when pulling 2cb8d32 on MikeRalphson:fix-args-parsing into 0523b60 on wework:master.


          Fix args parsing

2cb8d32

MikeRalphson force-pushed the fix-args-parsing branch from f4af245 to 2cb8d32 Compare

March 22, 2018 17:28

philsturgeon merged commit 8ee0b0f into wework:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment