Optionally support treating $ref like JSON Schema #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
commented
Apr 6, 2018
| @@ -822,11 +830,6 @@ function checkSecurity(security,openapi,options) { | |||
|
|
|||
| function validateSync(openapi, options, callback) { | |||
| setupOptions(options,openapi); | |||
| if (options.jsonschema) { | |||
There was a problem hiding this comment.
There was some old JSON Schema option which wasnt documented or used, so I killed it.
There was a problem hiding this comment.
It's documented here and used unless you removed it?
There was a problem hiding this comment.
Yeah I removed it :) I dont think its a feature we'll need in Speccy.
philsturgeon
commented
Apr 6, 2018
lint.js
Outdated
| } | ||
| return output; | ||
| } | ||
|
|
||
| function readableJsonSchemaMessages(err) { |
There was a problem hiding this comment.
The huge errors were making me upset, so this change ended up in this PR.
philsturgeon
force-pushed
the
feature/json-schema
branch
2 times, most recently
from
5c552a7
to
6715dad
Compare
philsturgeon
force-pushed
the
feature/json-schema
branch
2 times, most recently
from
d9d26f7
to
115c13a
Compare
philsturgeon
force-pushed
the
feature/json-schema
branch
from
115c13a
to
a0fd94b
Compare
|
I've trimmed this PR down a little for easier reviewing. The errors stuff has been moved out to #47. |
dangoosby
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use JSON Schema for contract testing, and want to reuse those JSON Schema models for OpenAPI documentation. Seeing as OpenAPI has imperfect (subset & superset) support for JSON Schema, we have to convert one to the other at runtime.
For now it is using an optional switch, which is a little annoying to do every time, but when #14 is done that'll just go in the config file.
Example