refactor(Message)!: remove Message.MessagePriority, add EMessagePriority

weyoss · Dec 11, 2023 · 702a01d · 702a01d
1 parent 29e8817
commit 702a01d
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 38 deletions.
diff --git a/src/lib/message/message-envelope.ts b/src/lib/message/message-envelope.ts
@@ -9,6 +9,7 @@
 
 import { parseExpression } from 'cron-parser';
 import {
+  EMessagePriority,
   EMessagePropertyStatus,
   IMessageSerialized,
   IQueueParams,
@@ -28,17 +29,6 @@ import { ExchangeFanOut } from '../exchange/exchange-fan-out';
 import { ExchangeTopic } from '../exchange/exchange-topic';
 
 export class MessageEnvelope {
-  static readonly MessagePriority = {
-    LOWEST: 7,
-    VERY_LOW: 6,
-    LOW: 5,
-    NORMAL: 4,
-    ABOVE_NORMAL: 3,
-    HIGH: 2,
-    VERY_HIGH: 1,
-    HIGHEST: 0,
-  };
-
   protected static defaultConsumeOptions: TMessageConsumeOptions = {
     ttl: 0,
     retryThreshold: 3,
@@ -58,7 +48,7 @@ export class MessageEnvelope {
 
   protected body: unknown = null;
 
-  protected priority: number | null = null;
+  protected priority: EMessagePriority | null = null;
 
   protected scheduledCron: string | null = null;
 
@@ -262,7 +252,10 @@ export class MessageEnvelope {
   }
 
   setPriority(priority: number): MessageEnvelope {
-    if (!Object.values(MessageEnvelope.MessagePriority).includes(priority)) {
+    if (
+      priority < EMessagePriority.HIGHEST ||
+      priority > EMessagePriority.LOWEST
+    ) {
       throw new MessageError('Invalid message priority.');
     }
     this.priority = priority;

diff --git a/src/lib/queue/errors/index.ts b/src/lib/queue/errors/index.ts
@@ -15,4 +15,3 @@ export { QueueNotEmptyError } from './queue-not-empty.error';
 export { QueueNotFoundError } from './queue-not-found.error';
 export { QueueRateLimitError } from './queue-rate-limit.error';
 export { QueueError } from './queue.error';
-export { QueueDeleteOperationError } from './queue-delete-operation.error';
diff --git a/src/lib/queue/errors/queue-delete-operation.error.ts b/src/lib/queue/errors/queue-delete-operation.error.ts
diff --git a/src/lib/queue/errors/queue-message-not-found.error.ts b/src/lib/queue/errors/queue-message-not-found.error.ts
diff --git a/types/message/message.ts b/types/message/message.ts
@@ -10,6 +10,17 @@
 import { TExchangeSerialized } from '../index';
 import { IQueueParams } from '../queue';
 
+export enum EMessagePriority {
+  HIGHEST,
+  VERY_HIGH,
+  HIGH,
+  ABOVE_NORMAL,
+  NORMAL,
+  LOW,
+  VERY_LOW,
+  LOWEST,
+}
+
 export enum EMessageProperty {
   ID,
   STATUS,