Skip to content

Commit

Permalink
refactor: rename _createRMessage to _createConsumableMessage
Browse files Browse the repository at this point in the history
  • Loading branch information
weyoss committed Dec 18, 2023
1 parent 5b5ce3a commit 7a138fd
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 6 deletions.
7 changes: 5 additions & 2 deletions src/lib/consumer/message-handler/consume-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { processingQueue } from './processing-queue';
import { ERetryAction } from './retry-message';
import { ELuaScriptName } from '../../../common/redis-client/redis-client';
import { Configuration } from '../../../config/configuration';
import { _createRMessage } from '../../message/_create-r-message';
import { _createConsumableMessage } from '../../message/_create-consumable-message';

export class ConsumeMessage {
protected keyQueueProcessing: string;
Expand Down Expand Up @@ -169,7 +169,10 @@ export class ConsumeMessage {
}
}
};
this.messageHandler.getHandler()(_createRMessage(msg), onConsumed);
this.messageHandler.getHandler()(
_createConsumableMessage(msg),
onConsumed,
);
} catch (error: unknown) {
this.logger.error(error);
this.unacknowledgeMessage(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ import {
TTopicParams,
} from '../../../types';

export function _createRMessage(msg: MessageEnvelope): IConsumableMessage {
export function _createConsumableMessage(
msg: MessageEnvelope,
): IConsumableMessage {
return {
getPublishedAt(): number | null {
return msg.getPublishedAt();
Expand Down
6 changes: 3 additions & 3 deletions src/lib/message/message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
IConsumableMessage,
} from '../../../types';
import { _getMessageStatus } from './_get-message-status';
import { _createRMessage } from './_create-r-message';
import { _createConsumableMessage } from './_create-consumable-message';
import { _getMessageState } from './_get-message-state';

export class Message {
Expand Down Expand Up @@ -57,7 +57,7 @@ export class Message {
else {
cb(
null,
reply.map((i) => _createRMessage(i)),
reply.map((i) => _createConsumableMessage(i)),
);
}
});
Expand All @@ -72,7 +72,7 @@ export class Message {
_getMessage(client, messageId, (err, reply) => {
if (err) cb(err);
else if (!reply) cb(new CallbackEmptyReplyError());
else cb(null, _createRMessage(reply));
else cb(null, _createConsumableMessage(reply));
});
});
}
Expand Down

0 comments on commit 7a138fd

Please sign in to comment.