Skip to content

Commit

Permalink
refactor(QueueMessages)!: remove redundant method deleteMessage()
Browse files Browse the repository at this point in the history
  • Loading branch information
weyoss committed Dec 9, 2023
1 parent 8279840 commit af21dff
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 28 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,4 @@ export abstract class QueueMessagesPaginatorAbstract implements IQueueMessages {
}
});
}

deleteMessage(
queue: string | IQueueParams,
messageId: string | string[],
cb: ICallback<void>,
): void {
_getCommonRedisClient((err, client) => {
if (err) cb(err);
else if (!client) cb(new CallbackEmptyReplyError());
else _deleteMessage(client, messageId, cb);
});
}
}
11 changes: 0 additions & 11 deletions src/lib/queue/queue-pending-messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,17 +71,6 @@ export class QueuePendingMessages implements IQueueMessages {
});
}

deleteMessage(
queue: string | IQueueParams,
messageId: string,
cb: ICallback<void>,
): void {
this.getQueueImplementation(queue, (err, pendingMessages) => {
if (err) cb(err);
else pendingMessages?.deleteMessage(queue, messageId, cb);
});
}

purge(queue: string | IQueueParams, cb: ICallback<void>): void {
this.getQueueImplementation(queue, (err, pendingMessages) => {
if (err) cb(err);
Expand Down
5 changes: 0 additions & 5 deletions types/queue-messages/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@ export interface IQueueMessages {
cb: ICallback<IQueueMessagesPage<Message>>,
): void;
purge(queue: string | IQueueParams, cb: ICallback<void>): void;
deleteMessage(
queue: string | IQueueParams,
messageId: string,
cb: ICallback<void>,
): void;
}

export interface IQueueMessagesCount {
Expand Down

0 comments on commit af21dff

Please sign in to comment.