Any chance of updating Redis to v4

[chris-elmstone]

Hello

The latest version of Redis allows for Promises and is a much nicer way of working, at the moment we use Handi-Redis to bypass this as using Redis 4 conflicts with this package's Redis 3.*.

I will look forward to your reply

Best Regards
Chris

[weyoss]

@chris-elmstone Thank you for opening this issue.

we use Handi-Redis to bypass this as using Redis 4 conflicts with this package's Redis 3.*.

Please provide an example to reproduce your conflicts.

I believe you should not have any issue when using a different redis version than the one that this library is using (thanks to NPM dependency resolution algorithm).

Here I am using redis@4.0.4:

{
  "dependencies": {
    "redis": "^4.0.4",
    "redis-smq": "^6.2.6"
  }
}

No conflict errors are expected when running this code:

import { Consumer } from 'redis-smq';
import { createClient } from 'redis';

const c = new Consumer();
c.run(() => {
    const r = createClient();
    r.connect().then(() => r.info()).then((i) => {
        console.log(i);
    });
});

[weyoss]

Closing as resolved

[PhilHannent]

Good afternoon weyoss,

I am having a go at trying to use redis v4 with redis-smq and there is a type conflict:

node_modules/redis-smq/dist/types/index.d.ts:3:10 - error TS2305: Module '"redis"' has no exported member 'ClientOpts'.

3 import { ClientOpts, Multi, RedisClient as NodeRedis } from 'redis';
           ~~~~~~~~~~

node_modules/redis-smq/dist/types/index.d.ts:3:22 - error TS2305: Module '"redis"' has no exported member 'Multi'.

3 import { ClientOpts, Multi, RedisClient as NodeRedis } from 'redis';

They appear to have changed the ClientOps type to be RedisClientOptions

redis/node-redis#1673

But redis-smq uses the older naming convention:
import { Callback, ClientOpts, Multi, RedisClient as NodeRedis } from 'redis';

[weyoss]

@PhilHannent I have re-opened this issue as it seems that there is a conflict problem that does not always occur.

Please provide a full working example to reproduce your issue.

You can try to run code from my previous comment #78 (comment)

[weyoss]

Using

{
  "dependencies": {
    "redis": "^4.0.4",
    "redis-smq": "^6.2.6"
  }
}

I am not having any issue, including your listing:

node_modules/redis-smq/dist/types/index.d.ts:3:10 - error TS2305: Module '"redis"' has no exported member 'ClientOpts'.

3 import { ClientOpts, Multi, RedisClient as NodeRedis } from 'redis';
           ~~~~~~~~~~

node_modules/redis-smq/dist/types/index.d.ts:3:22 - error TS2305: Module '"redis"' has no exported member 'Multi'.

3 import { ClientOpts, Multi, RedisClient as NodeRedis } from 'redis';

[weyoss]

The explanation is obvious. When a module is being used in different libraries, NPM handles this situation depending on the following cases:

1. If the module version is the same between all the libraries, then the module is installed in the main node_modules directory and is used by all the libraries.
2. If the module version is NOT the same (in our case redis v4 and v3) between some libraries then each library uses its own module version and the module is installed in a local node_modules directory of the library.

[PhilHannent]

Good morning weyoss!

To clarify, having the two side by side isn't the issue. It is where we are attempting to have one configuration for both our redis usage and for redis-smq. Because there is a difference in how the redis versions structure their configuration, it seems like we cannot re-use the same structure.

I'll create a small example.

[weyoss]

@PhilHannent I got your point!

So the issue is about using the redis configuration of your application which is using redis@v4 for redis-smq.

In such case, definitely you are going to have the issue that you mentioned before.

I'll create a small example.

There is no more need to create an example. The issue has been clarified. Thank you.

[weyoss]

Before redis is upgraded to v4, the only solution is to use a separate redis configuration for redis-smq.

Please follow #86 to stay tuned about upgrading to redis@v4

[weyoss]

Closing as resolved.