Confirmation before quitting #280
Comments
When confirmation is enabled, a really basic overlay is
rendered over the top of the tab to request confirmation.
The default key assignment for CloseCurrentTab now
has confirmation enabled.
```lua
action=wezterm.action{CloseCurrentTab={confirm=true}}
action=wezterm.action{CloseCurrentTab={confirm=false}}
```
refs: #157
refs: #280
|
@wez this is done (in b2911cc) and can be closed? Maybe @JoyceBabu you can try the latest release? |
|
We don't have an overall confirm to quit the app option, or one for closing a window, so this isn't quite done. |
|
@bew As mentioned above, the feature request was for confirming the app exit action. There was a mistake in the original post. I had configured |
Make pane, tab, window close confirmations use the same core function. Make that function accept mouse input so that closing the window with a mouse click doesn't require switching to the keyboard to confirm the close. refs: #280
|
I added window close confirmation to master (in 5787bdf); that'll show up in the nightly downloads in the next hour or so. I'm on Linux at the moment so I didn't have an opportunity to test what happens with |
|
@wez Pressing |
This is defined as a trait method on Pane (default: false), and has the obvious transitive equivalent methods in Tab and Window (eg: if all contained items are `can_close_without_prompting`, then that container is also `can_close_without_prompting`). The intent is to avoid bothering the user to confirm closing a window when the content is not stateful and doesn't warrant it. For example: the window that is displayed in the event of a configuration error really shouldn't prompt to the user to confirm closing it. All termwiztermtab panes are `can_close_without_prompting==true` to effect this policy. In the future, we could teach LocalPane to lookup the session leader process against a list of "uninteresting" or "stateless" processes and return an appropriate result (as suggested in #280). That functionality is NOT part of this commit.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your feature request related to a problem? Please describe.
I have configured wezterm to quit on
CMD+q. But I pressed the combination by mistake, when trying to pressCMD+1for activating the first tab, and the window got closed immediately.Describe the solution you'd like
Display a confirmation dialog before quitting.
iTerm allows configuring a list of programs (shell and tmux by default). If another program is running, then iTerm asks for user confirmation before quitting.
Describe alternatives you've considered
Another solution is to change the shortcut to a key combination that cannot be pressed by accident. But it is convenient to configure it as per the convention followed by other applications.
The text was updated successfully, but these errors were encountered: