-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to quickly display a help overlay #3335
Comments
umh, how about having different modes in the command palette itself? inspired from vs code, where typing |
Good idea. Didn't think of that. Would even be necessary to have different modes in the command palette, just showing the assigned shortcut for each command could also do the job. |
😃 here:
|
I started using Helix and Wezterm around the same time this year. A feature I love in Helix is the ability to trigger menus with hotkeys that then show all the other hotkeys for that action. Things like splitting panes, searching, copy mode could all benefit from this. An easy win though I think is to display the currently bound hotkey in the command pallet in search results. |
For items in the main set of key assignments, show the keyboard shortcut to the right. Some items have multiple key assignments; we show only the first one. We'll probably want to be a bit smarter. For instance, both linux and windows tend to occupy the Windows/Super key assignments, so we should probably prioritize showing the Ctrl+Shift variants on those platforms. refs: #3335
Wow that was fast, I just compiled locally and tested thanks for such a fast turn around! |
hey, how about using shortcuts for "Shit" "Ctrl" "Alt" & "Opt" "Cmd" to save space? so like: |
I tried using symbols but at the default font size for the palette, and even a bit larger, they render too small to be legible. I could potentially make the rendering for these symbols configurable, so if you've configured a large enough font size that the symbols might be more useful, then you could choose that. |
yeah, the symbol for opt key how common is "Super" key (the OS key right?) in wezterm? 😉 superset symbol: P.S.: Found one more: Modifier Key |
added a new `ui_key_cap_rendering` option that accepts the following values: ```lua -- Super, Meta, Ctrl, Shift config.ui_key_cap_rendering = 'UnixLong' -- Super, M, C, S config.ui_key_cap_rendering = 'Emacs' -- Apple macOS style symbols config.ui_key_cap_rendering = 'AppleSymbols' -- Win, Alt, Ctrl, Shift config.ui_key_cap_rendering = 'WindowsLong' -- Like WindowsLong, but using a logo for the Win key config.ui_key_cap_rendering = 'WindowsSymbols' ``` refs: #3335
The commit I just pushed adds a config option to control this: -- Super, Meta, Ctrl, Shift
config.ui_key_cap_rendering = 'UnixLong'
-- Super, M, C, S
config.ui_key_cap_rendering = 'Emacs'
-- Apple macOS style symbols
config.ui_key_cap_rendering = 'AppleSymbols'
-- Win, Alt, Ctrl, Shift
config.ui_key_cap_rendering = 'WindowsLong'
-- Like WindowsLong, but using a logo for the Win key
config.ui_key_cap_rendering = 'WindowsSymbols' |
On macOS prefer CMD, but on other platform prioritize shortcuts that don't use CMD, as those tend to reserve the CMD based shortcuts for the system. Allow specifying how many shortcuts to show if an action has multiple assignments. The default is 1. refs: #3335
thanks a lot for the stable release. with command palette & shown shortcuts, i can finally use the panes, search and other features of wezterm which earlier i just couldn't remember & reinforce in memory |
$ wezterm --config ui_key_cap_rendering='Emacs'
ERROR wezterm > runtime error: [string "--config ui_key_cap_rendering=Emacs"]:5: Emacs evaluated as nil. Check for missing quotes or other syntax issues
stack traceback:
[C]: in ?
[C]: in function 'error'
[string "--config ui_key_cap_rendering=Emacs"]:5: in main chunk; terminating Resolved with following comment from wezi tried combinations with appending per the commit history for the release tag: 20230326-111934-3666303c, this commit ca283c1 is included in the release. so, something is wrong, either in my usage, or it's a bug i guess |
As the error message suggests, you need to fix the quoting on the command line, because the shell tokenizer/parser has a stage called Quote Removal that strips out any unquoted quotes.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Especially new users are often struggling to find the correct shortcut. It would be helpful to have an action that can be assigned to a key binding, which temporary brings up an overlay (similar to how the command palette is shown), that shows a cheat sheet of the currently effective key bindings.
By default, this could have some default shortcut assigned, like Ctrl + Shift + ?.
The text was updated successfully, but these errors were encountered: