wezterm can't deal with grayscale images in png format

[wrvsrx]

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20230517-063445-6bcb8eed

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

The wezterm imgcat command fails to correctly display grayscale images and wezterm cannot read grayscale images as backgrounds.

I discovered that the issue stems from this commit, which does not handle the L8 format (e.g., grayscale images) in the fix for #3529, causing errors to occur.

To Reproduce

Below is how to reproduce the bug using wezterm imgcat.

1. find an grayscale png

   

2. wezterm imgcat <filename>

3. Something like

   19:05:16.147  ERROR  wezterm_gui::glyphcache > Error decoding image: unimplemented PNG conversion from L8
   19:05:16.241  WARN   wezterm_gui::glyphcache > image decoder thread terminated
   

   will appear in log and image is not displayed.

Configuration

no config

Expected Behavior

There should not be such log and the image should be displayed

Logs

19:05:16.147 ERROR wezterm_gui::glyphcache > Error decoding image: unimplemented PNG conversion from L8
19:05:16.241 WARN wezterm_gui::glyphcache > image decoder thread terminated

Anything else?

No response

[wez]

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

[wrvsrx]

Thank! I can verify it has been fixed on windows nightly version.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.