Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloseCurrentPane kills shell but pane itself not closing #4030

Closed
Lakroft opened this issue Jul 20, 2023 · 4 comments
Closed

CloseCurrentPane kills shell but pane itself not closing #4030

Lakroft opened this issue Jul 20, 2023 · 4 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@Lakroft
Copy link

Lakroft commented Jul 20, 2023

What Operating System(s) are you seeing this problem on?

macOS

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

wezterm 20230712-072601-f4abf8fd

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

No, and I'll explain why below

Describe the bug

I'm using latest brew version.
In configs I've got a key binding:
{ key = 'w', mods = mod.SUPER, action = act.CloseCurrentPane { confirm = false } },
When I do 'COMMAND + W' or press 'Close current Pane' in Shell menu, pane's shell stops responding to any input but the pane is still there, it's not closing.
The only error message in logs I've got if I switch to alive pane and then back to 'closed' one. The message says:
12:41:39.297 ERROR wezterm_gui::frontend > Error reconciling PaneFocused notification: pane 3 not found

To Reproduce

Add and load configuration.
Press 'COMMAND + W' or 'Close current Pane' in Shell menu

Configuration

{ key = 'w', mods = mod.SUPER, action = act.CloseCurrentPane { confirm = false } },

Expected Behavior

The pane is closed.

Logs

12:41:39.297 ERROR wezterm_gui::frontend > Error reconciling PaneFocused notification: pane 3 not found

Anything else?

No response

@Lakroft Lakroft added the bug Something isn't working label Jul 20, 2023
@paul-hansen
Copy link
Sponsor

This happens for me if I have CloseOnCleanExit set in my config:

config.exit_behavior = "CloseOnCleanExit"

With that line I get a similar error:

ERROR  wezterm_gui::frontend       > Error reconciling PaneFocused notification: pane 8 not found

Commenting the line out makes it work again. Not a great solution because I did want to have CloseOnCleanExit set, but hopefully will help track it down.

wez added a commit that referenced this issue Aug 28, 2023
Repro for this issue was:

```console
$ WEZTERM_LOG=mux=trace,info ./target/debug/wezterm -n --config 'exit_behavior="CloseOnCleanExit"'
```

Then:

* Split left/right
* CloseCurrentPane

refs: #4030
@wez
Copy link
Owner

wez commented Aug 28, 2023

@paul-hansen yes, that helped, thank you!

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Aug 28, 2023
@paul-hansen
Copy link
Sponsor

Was able to build from source on the latest main branch and it's working great!

Really loving wezterm, awesome work! I'm between jobs at the moment but you're on my list of people I want to sponsor once I get that sorted.

@wez wez closed this as completed Jan 27, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

3 participants