Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad image output when using kitty protocol with width and height specified #4233

Closed
CarterLi opened this issue Sep 2, 2023 · 4 comments
Closed
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@CarterLi
Copy link

CarterLi commented Sep 2, 2023

What Operating System(s) are you seeing this problem on?

Linux Wayland

Which Wayland compositor or X11 Window manager(s) are you using?

Mutter

WezTerm version

20230828-220414-99c96139

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

image

To Reproduce

echo -e "\e_Ga=T,f=100,t=f,c=20,r=10;$(realpath ./OpenSuse.png | tr -d '\n' | base64)\e\\"

Image used: x

Configuration

no config

Expected Behavior

Works like kitty

image

Logs

No response

Anything else?

Specifying width and height does work fine with iterm image protocol

@CarterLi CarterLi added the bug Something isn't working label Sep 2, 2023
@CarterLi
Copy link
Author

CarterLi commented Sep 2, 2023

Another issue: if you display an image file multiple times, the next image hides the previous one.

EDIT: Found #3918

wez added a commit that referenced this issue Jan 28, 2024
refs: #1156
refs: #1156
refs: #1663
refs: #2084
refs: #2422
refs: #2761
refs: #3918
refs: #4233
refs: #4847
@wez
Copy link
Owner

wez commented Jan 28, 2024

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Jan 28, 2024
@CarterLi
Copy link
Author

I can confirm the fix. Thanks.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants