Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented options #461

Closed
22 of 24 tasks
bew opened this issue Feb 6, 2021 · 4 comments
Closed
22 of 24 tasks

Undocumented options #461

bew opened this issue Feb 6, 2021 · 4 comments
Labels
docs Primarily or only affects documentation

Comments

@bew
Copy link
Sponsor Contributor

bew commented Feb 6, 2021

Here are the list of undocumented options, based on this version of the config: config/src/lib.rs@b6d85f94


For the record, here is how I made the list:

  1. copy all lines in Config struct (example) in an empty file

  2. (vim) Remove all docs with :v/pub/d

  3. (vim) Cleanup the lines with :%norm dndwf:D

  4. (vim) Sort all options :%sort

  5. save file to all_options

  6. find missing docs with:

    while read opt; do
      rg $opt docs/config/ > /dev/null || echo $opt
    done <all_options
@bew bew added the bug Something isn't working label Feb 6, 2021
@wez wez added docs Primarily or only affects documentation and removed bug Something isn't working labels Feb 6, 2021
wez added a commit that referenced this issue Feb 20, 2021
@bew
Copy link
Sponsor Contributor Author

bew commented Apr 5, 2021

The last one from that list is ratelimit_mux_line_prefetches_per_second just want to note that I have no idea how to document that.

I re-ran the steps to find undocumented options, the only new one is experimental_shape_post_processing which I guess won't be documented, right?

@wez
Copy link
Owner

wez commented Apr 5, 2021

Yeah, I think we can close this: I'm likely to change ratelimit_mux_line_prefetches_per_second and I don't expect anyone to need to change that value in the meantime.

@bew
Copy link
Sponsor Contributor Author

bew commented Apr 5, 2021

So be it!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Primarily or only affects documentation
Projects
None yet
Development

No branches or pull requests

2 participants