Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timg get pixelized video when ssh #4651

Closed
youngtuotuo opened this issue Dec 7, 2023 · 4 comments
Closed

timg get pixelized video when ssh #4651

youngtuotuo opened this issue Dec 7, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@youngtuotuo
Copy link
Sponsor

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20231203-124028-e3cd2e93

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Video not correclty displayed through timg on windows platform through ssh.
I can see normal frame from macos, also ssh to the same machine.

Windows wezterm version: 20230712-072601-f4abf8fd and 20231203-124028-e3cd2e93
Macos wezterm version (installed via homebrew): 20230712-072601-f4abf8fd

Here's the screencast on windows version
Animation_c

To Reproduce

  1. Ssh to a ubuntu20.04 machine.
  2. Use timg to view video.
  3. Video is pixelized without using -p flag.
  4. Video has correct resolution with -pi flag but the frame are at wrong positions (see the gif above).

Configuration

no config

Expected Behavior

Correct frame resolution and correct position.

Logs

A fresh overlay after runnging timg

Debug Overlay
wezterm version: 20231203-124028-e3cd2e93 x86_64-pc-windows-msvc
Window Environment: Windows
WebGPU: name=NVIDIA GeForce RTX 3070 Ti, device_type=DiscreteGpu, backend=Vulkan, driver=NVIDIA, driver_info=546.17, vendor=4318, device=9346
Enter lua statements or expressions and hit Enter.
Press ESC or CTRL-D to exit

Anything else?

First, appreciate for the awesome work. This terminal emulator is really good.

I've seached the following keywords in google and github search bar (both in wezterm and timg repo):
wezterm image protocol error, timg ssh wrong frame position, windows wezterm timg, timg animations
But I can't found the same issues and workaround.

The most related one I think is #3882.
I faced similar filckering with wezterm's ssh multiplexer (both on macos and win), but that won't effect my workflow much since I can switch to normal ssh connection and then all works fine with macos.

Also, I've tested other timg's -p values (k,s,h,q), all not work properly.

I apologize if this is a duplicate issue.

@youngtuotuo youngtuotuo added the bug Something isn't working label Dec 7, 2023
@wez
Copy link
Owner

wez commented Dec 22, 2023

What ssh client are you using? Note that the windows command line versions of ssh will spawn a separate conpty instance, and conpty does not play well with image protocols.

I would recommend using wezterm ssh (or wezterm's ssh domains) if you want to use image protocols; that bypasses conpty.

Learn more about ConPTY here: https://wezfurlong.org/wezterm/what-is-a-terminal.html#windows-and-conpty

@wez wez added the waiting-on-op Waiting for more information from the original poster label Dec 22, 2023
@youngtuotuo
Copy link
Sponsor Author

@wez Thx for the explanation, I learn a new concept!
Yes, I'm using the windows cli version ssh. I'll try more combination and udpate the results here.

@github-actions github-actions bot removed the waiting-on-op Waiting for more information from the original poster label Dec 22, 2023
@wez wez added the waiting-on-op Waiting for more information from the original poster label Dec 22, 2023
@youngtuotuo
Copy link
Sponsor Author

youngtuotuo commented Dec 26, 2023

wezterm ssh solves the issue. So I'll close this. Thx @wez.

@github-actions github-actions bot removed the waiting-on-op Waiting for more information from the original poster label Dec 26, 2023
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants