Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs in fancy bar take time to update after closing a tab #4880

Closed
lokesh-krishna opened this issue Jan 28, 2024 · 7 comments
Closed

Tabs in fancy bar take time to update after closing a tab #4880

lokesh-krishna opened this issue Jan 28, 2024 · 7 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@lokesh-krishna
Copy link
Contributor

What Operating System(s) are you seeing this problem on?

Linux Wayland

Which Wayland compositor or X11 Window manager(s) are you using?

Hyprland

WezTerm version

wezterm 20240127-131129-6de7c604

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Creating a new tab immediately updates the fancy tab bar but upon closing a tab, it takes the bar a second or two to update. I can get it to update instantly by creating a new tab again.

To Reproduce

Create a new tab.
Exit/quit the tab.
Tab bar continues to show the closed tab for a second or two.

Configuration

config.use_fancy_tab_bar = true

Expected Behavior

Quitting a tab instantly updates the tab bar, the same way that creating one instantly updates it.

Logs

No response

Anything else?

No response

@lokesh-krishna lokesh-krishna added the bug Something isn't working label Jan 28, 2024
@bakageddy
Copy link

Same Occurs for me in X11 too.
Version: 20240127-131129-6de7c604

@gegoune
Copy link
Sponsor

gegoune commented Jan 28, 2024

Same observed with use_fancy_tab_bar = false on wezterm 20240127-125307-11c1dd65.

@jankatins
Copy link
Sponsor Contributor

Can also confirm on mac (don't set use_fancy_tab_bar, so probably false).

Probably related to 7f3a835 ? So probably another place/state when to call self.update_title_post_status(); ?

@kerjes
Copy link

kerjes commented Jan 28, 2024

Have the same problem with version: wezterm 20240127-113634-bbcac864

tab-close-delay.mp4

wez added a commit that referenced this issue Jan 28, 2024
@wez
Copy link
Owner

wez commented Jan 28, 2024

This should be resolved now in main.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the fix and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Jan 28, 2024
@kerjes
Copy link

kerjes commented Jan 28, 2024

Tested "nightly build, version: "wezterm 20240128-080125-0b2b85d5" and the delay is gone, works perfectly 💯

@wez wez closed this as completed Feb 3, 2024
Copy link

github-actions bot commented Mar 5, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

6 participants