Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wezterm crashes on suspend on wayland #5079

Closed
sjcobb2022 opened this issue Feb 26, 2024 · 3 comments
Closed

Wezterm crashes on suspend on wayland #5079

sjcobb2022 opened this issue Feb 26, 2024 · 3 comments
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@sjcobb2022
Copy link

What Operating System(s) are you seeing this problem on?

Linux Wayland

Which Wayland compositor or X11 Window manager(s) are you using?

Hyprland

WezTerm version

95581d8

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

On suspend, wezterm crashes with an unimplemented error.

To Reproduce

  • Hyprland, built from branch main at commit af0c8e299bbbf1726cecfde683137cfd4a6b8642
  • Wezterm 95581d8
  • Start wezterm
  • Suspend system

Configuration

local wezterm = require 'wezterm';

return {
  font = wezterm.font("FiraCode Nerd Font"),
  font_size = 12.0,
  color_scheme = 'tokyo-city-terminal-dark',
  hide_tab_bar_if_only_one_tab = true,
  window_close_confirmation = "NeverPrompt",
  check_for_updates = false,
  term='wezterm'
}

Expected Behavior

It does not crash.

Logs

09:55:33.945 ERROR env_bootstrap > panic at window/src/os/wayland/seat.rs:70:9 - not yet implemented
0: env_bootstrap::register_panic_hook::{{closure}}
1: std::panicking::rust_panic_with_hook
2: std::panicking::begin_panic_handler::{{closure}}
3: std::sys_common::backtrace::__rust_end_short_backtrace
4: rust_begin_unwind
5: core::panicking::panic_fmt
6: core::panicking::panic
7: <window::os::wayland::state::WaylandState as wayland_client::event_queue::Dispatch<wayland_client::protocol::wl_seat::WlSeat,smithay_client_toolkit::seat::SeatData>>::event
8: wayland_client::event_queue::queue_callback
9: wayland_client::event_queue::EventQueue::dispatching_impl
10: <window::os::wayland::connection::WaylandConnection as window::connection::ConnectionOps>::run_message_loop
11: wezterm_gui::run_terminal_gui
12: wezterm_gui::main
13: std::sys_common::backtrace::__rust_begin_short_backtrace
14: std::rt::lang_start::{{closure}}
15: std::rt::lang_start_internal
16: std::rt::lang_start
17: __libc_start_call_main
18: __libc_start_main@GLIBC_2.2.5
19: _start

Anything else?

I am unsure whether this is being worked on, as this has been left unimplemented after the tzx wayland rewrite.

Specifically it is the function.

    fn remove_capability(
        &mut self,
        _conn: &Connection,
        _qh: &QueueHandle<Self>,
        _seat: WlSeat,
        _capability: smithay_client_toolkit::seat::Capability,
    ) {
        todo!()
    }
@sjcobb2022 sjcobb2022 added the bug Something isn't working label Feb 26, 2024
@cjearls
Copy link

cjearls commented Mar 14, 2024

I'm seeing the same behavior on Sway, and it appears that #5154 is due to the same todo!

@wez
Copy link
Owner

wez commented May 4, 2024

Fixed by #5276

@wez wez closed this as completed May 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

3 participants