-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wezterm not starting on Hyprland >= 0.37.0 #5264
Conversation
I can confirm this works for me on Arch using Hyprland, going to use your fork for now haha thank you. Been missing using |
It may not be related to your fix, but after every suspend wezterm crashes (it wasn't before I updated). DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau. 16:42:49.002 ERROR env_bootstrap > panic at window/src/os/wayland/seat.rs:70:9 - not yet implemented 0: env_bootstrap::register_panic_hook::{{closure}} 1: std::panicking::rust_panic_with_hook 2: std::panicking::begin_panic_handler::{{closure}} 3: std::sys_common::backtrace::__rust_end_short_backtrace 4: rust_begin_unwind 5: core::panicking::panic_fmt 6: core::panicking::panic 7: >::event 8: wayland_client::event_queue::queue_callback 9: wayland_client::event_queue::EventQueue::dispatching_impl 10: ::run_message_loop 11: wezterm_gui::run_terminal_gui 12: wezterm_gui::main 13: std::sys_common::backtrace::__rust_begin_short_backtrace 14: std::rt::lang_start::{{closure}} 15: std::rt::lang_start_internal 16: std::rt::lang_start 17: __libc_start_call_main 18: __libc_start_main@@GLIBC_2.34 19: _start UPD: #5079 |
This is because there are many Could you try merging my patch into the stable branch of Wezterm for testing? |
I took your patch and #5173 and now wezterm works ok on wayland. Thanks. |
Hi, many thanks for your PR. I built your branch and encountered a new issue.
This happened when I enabled the fraction scale in Hyprland(v0.39.1). For example:
It works well if the scaling is 1. |
It has nothing to do with this PR. Probably #5149 |
Hi, thanks for this! Can you try this with sway? In particular, I'm concerned that this may cause a regression there; see #884 |
I just tested this patch on sway. It seemed to work in both normal window and scratchpad without pausing. |
Thanks! |
Checked on master branch. |
See [#5264](wez/wezterm#5264)
Fix: #5103
The explanation is here: #5103 (comment)
I didn't update
do_paint
because I'm not familiar with the logic there.