Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wezterm not starting on Hyprland >= 0.37.0 #5264

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Fix wezterm not starting on Hyprland >= 0.37.0 #5264

merged 4 commits into from
Apr 29, 2024

Conversation

fioncat
Copy link
Contributor

@fioncat fioncat commented Apr 4, 2024

Fix: #5103

The explanation is here: #5103 (comment)

I didn't update do_paint because I'm not familiar with the logic there.

@fioncat
Copy link
Contributor Author

fioncat commented Apr 4, 2024

@Rolv-Apneseth
Copy link

I can confirm this works for me on Arch using Hyprland, going to use your fork for now haha thank you. Been missing using wezterm.

@woojiq
Copy link

woojiq commented Apr 6, 2024

It may not be related to your fix, but after every suspend wezterm crashes (it wasn't before I updated).

DRM kernel driver 'nvidia-drm' in use. NVK requires nouveau.
16:42:49.002  ERROR  env_bootstrap > panic at window/src/os/wayland/seat.rs:70:9 - not yet implemented
   0: env_bootstrap::register_panic_hook::{{closure}}
   1: std::panicking::rust_panic_with_hook
   2: std::panicking::begin_panic_handler::{{closure}}
   3: std::sys_common::backtrace::__rust_end_short_backtrace
   4: rust_begin_unwind
   5: core::panicking::panic_fmt
   6: core::panicking::panic
   7: >::event
   8: wayland_client::event_queue::queue_callback
   9: wayland_client::event_queue::EventQueue::dispatching_impl
  10: ::run_message_loop
  11: wezterm_gui::run_terminal_gui
  12: wezterm_gui::main
  13: std::sys_common::backtrace::__rust_begin_short_backtrace
  14: std::rt::lang_start::{{closure}}
  15: std::rt::lang_start_internal
  16: std::rt::lang_start
  17: __libc_start_call_main
  18: __libc_start_main@@GLIBC_2.34
  19: _start

thread 'main' panicked at window/src/os/wayland/seat.rs:70:9:
not yet implemented
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
thread panicked while processing panic. aborting.
Aborted (core dumped)

UPD: #5079

@fioncat
Copy link
Contributor Author

fioncat commented Apr 7, 2024

It may not be related to your fix, but after every suspend wezterm crashes (it wasn't before I updated).

This is because there are many todo items in the wayland/seat.rs file of the main branch. Perhaps Wezterm is currently refactoring some of its Wayland implementations?

Could you try merging my patch into the stable branch of Wezterm for testing?

@woojiq
Copy link

woojiq commented Apr 7, 2024

Could you try merging my patch into the stable branch of Wezterm for testing?

I took your patch and #5173 and now wezterm works ok on wayland. Thanks.

@fioncat fioncat changed the title fix(wayland): ensure repaint event is sent in show Fix wezterm not starting on Hyprland >= 0.37.0 Apr 8, 2024
@yuchanns
Copy link

yuchanns commented Apr 23, 2024

Hi, many thanks for your PR. I built your branch and encountered a new issue.

ERROR  wezterm_gui                     > running message loop: Io error: Broken pipe (os error 32); terminating

This happened when I enabled the fraction scale in Hyprland(v0.39.1).

For example:

monitor = eDP-1, preferred, 0x0, 2

It works well if the scaling is 1.

@woojiq
Copy link

woojiq commented Apr 23, 2024

This happened when I enabled the fraction scale in Hyprland(v0.39.1).

It has nothing to do with this PR. Probably #5149

@wez
Copy link
Owner

wez commented Apr 29, 2024

Hi, thanks for this! Can you try this with sway? In particular, I'm concerned that this may cause a regression there; see #884

@yutkat
Copy link
Sponsor Contributor

yutkat commented Apr 29, 2024

I just tested this patch on sway.

It seemed to work in both normal window and scratchpad without pausing.

@wez wez merged commit 42d62fa into wez:main Apr 29, 2024
1 check was pending
wez added a commit that referenced this pull request Apr 29, 2024
@wez
Copy link
Owner

wez commented Apr 29, 2024

Thanks!

@Anakael
Copy link

Anakael commented Apr 29, 2024

Checked on master branch.
Now it launches with wayland enabled.

xarvex added a commit to xarvex/dotfyls that referenced this pull request Jun 21, 2024
saep pushed a commit to saep/wezterm that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wezterm not starting with wayland_enable=1 on Hyprland-git
8 participants