Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Skip close confirmation when pane(s) are idle #843

Closed
God-damnit-all opened this issue Jun 2, 2021 · 2 comments
Closed

[Windows] Skip close confirmation when pane(s) are idle #843

God-damnit-all opened this issue Jun 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@God-damnit-all
Copy link

God-damnit-all commented Jun 2, 2021

"Really kill this tab and all contained panes?" appears on every tab close, even if the shell is inactive and has no child processes.

Is your feature request related to a problem? Please describe.
A solution was made for macOS and Linux here: #562. But, there's nothing yet for Windows.

Describe the solution you'd like
Through the ConPTY API, there might have a way to detect if cmd, ssh, pwsh, or powershell is inactive, maybe by checking to see if its ready to receive input.

@God-damnit-all God-damnit-all added the enhancement New feature or request label Jun 2, 2021
@wez
Copy link
Owner

wez commented Jun 10, 2021

I looked into this today; the solution actually does work on windows, it's just that the default https://wezfurlong.org/wezterm/config/lua/config/skip_close_confirmation_for_processes_named.html doesn't include any windows shell proccesses.

I'm pushing a commit that adds cmd.exe, pwsh.exe and powershell.exe to that list.

I don't think ssh.exe is a safe thing to add by default, as there is no way to see inside the ssh session to tell if you would lose anything important, but you are welcome to set that config for yourself in your wezterm.lua

@wez wez closed this as completed in cc19aac Jun 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants