Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Drag and Drop for X11 #5316

Closed
wants to merge 2 commits into from
Closed

Implement Drag and Drop for X11 #5316

wants to merge 2 commits into from

Conversation

ssiegel
Copy link
Contributor

@ssiegel ssiegel commented Apr 18, 2024

This implements accepting files/folders via drag and drop as on the
other platforms. It adds receiving URLs dragged e.g. from a browser and
plain text.

For filenames and urls an additional space is inserted after the last
item to enable adding more files and urls with another drag-and-drop
operation without the need to manually enter the space in between.

This is the last platform to resolve #640

This is the last platform to resolve wez#640
For filenames and urls an additional space is inserted after the last
item to enable adding more files and urls with another drag-and-drop
operation without the need to manually enter the space in between.
@ssiegel
Copy link
Contributor Author

ssiegel commented Apr 18, 2024

The change to add the space after the dropped files/urls might be up for debate, but it is what I'm used to from Konsole. I don't see how an additional space would be undesirable anywhere where I might want to drop filenames. Even if there might be a situation, then deleting it with a single backspace seems easier to me than having to change focus and press space between multiple drag-and-drop operations.

wez added a commit that referenced this pull request May 5, 2024
Reduce some nesting and make it a little easier to follow.

refs: #5316
@wez wez closed this in 65a84dd May 5, 2024
@wez
Copy link
Owner

wez commented May 5, 2024

Thank you!

saep pushed a commit to saep/wezterm that referenced this pull request Jul 14, 2024
Reduce some nesting and make it a little easier to follow.

refs: wez#5316
saep pushed a commit to saep/wezterm that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag & Drop files/folders
2 participants