Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VoidSymbol keycode to be seen by wezterm #759

Merged
merged 4 commits into from
May 7, 2021

Conversation

digitallyserviced
Copy link
Contributor

When using setxkbmap to disable the functionality of CapsLock, it shows as 0x00FFFFFF VoidSymbol keycode. That was not being picked up by wezterm.

These changes allow it to be picked up as VoidSymbol so the CapsLock key can be used without any unintended side-effects.

This is how xev and other applications see it once disabled and could even be used when disabling other keys to have them be used similarly.

Makes for a great LEADER independent from anything else without going shift crazy.

Copy link
Owner

@wez wez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! What do you think about not including void symbol at the terminal layer? There's no way to encode that concept in terminal input/output, so it doesn't seem necessary.

termwiz/src/input.rs Outdated Show resolved Hide resolved
wezterm-gui/src/termwindow/keyevent.rs Outdated Show resolved Hide resolved
@wez
Copy link
Owner

wez commented May 4, 2021

Please also cargo fmt and update the PR to make the CI happy!

@digitallyserviced digitallyserviced marked this pull request as draft May 4, 2021 14:13
@digitallyserviced digitallyserviced marked this pull request as ready for review May 7, 2021 01:59
@digitallyserviced
Copy link
Contributor Author

I think I cleaned up the unnecessary KeyCodes so that only where it needs to be added for key events and bindings are in there. Also cargo fmt and re-tested.

@wez wez merged commit 2add312 into wez:main May 7, 2021
@wez
Copy link
Owner

wez commented May 7, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants