Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terminfo] add smxx/rmxx, purge blink #905

Merged
merged 3 commits into from Jul 12, 2021

Conversation

dankamongmen
Copy link
Contributor

Testing with WezTerm nightly indicates no blink support
available through the xterm \E[5m, and I didn't see any
support in the code -- purge it. smxx and rmxx, meanwhile,
have been added to indicate support for struck text.

Testing with WezTerm nightly indicates no blink support
available through the xterm \E[5m, and I didn't see any
support in the code -- purge it. smxx and rmxx, meanwhile,
have been added to indicate support for struck text.
@dankamongmen
Copy link
Contributor Author

2021-06-27-101122_1254x1417_scrot

huh, i guess i need to edit termwiz/data/xterm-256color-italic.terminfo as well, don't i?

@wez
Copy link
Owner

wez commented Jun 27, 2021

#904 is adding blink support!

termwiz/data/xterm-256color-italic.terminfo is the termwiz crate's fallback for running on a modern xterm compatible system when we either can't find terminfo or are running on windows with virtual terminal support. It's also used by wezterm's format function, but that should really target wezterm.terminfo instead.

So: if xterm supports smxx and rmxx then it makes sense to add it to xterm-256color-italic.terminfo, but otherwise not!

termwiz/data/wezterm.terminfo Outdated Show resolved Hide resolved
@wez wez merged commit d337677 into wez:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants