tmux-cc: force DcsPassThrough in tmux-cc mode #977
Conversation
|
The issue in the current implementation is that if My implementation here is obviously a naive one. I hope my description of the issue is clear. |
| @@ -173,6 +180,9 @@ impl<'a, F: FnMut(Action)> VTActor for Performer<'a, F> { | |||
| data: vec![], | |||
| }); | |||
| } else { | |||
| if byte == b'p' && params == vec![1000] { | |||
There was a problem hiding this comment.
I think we can avoid making a vec for this; the vec is undesirable because it represents an unconditional heap allocation just for a comparison.
| if byte == b'p' && params == vec![1000] { | |
| if byte == b'p' && params == [1000] { |
| @@ -173,6 +180,9 @@ impl<'a, F: FnMut(Action)> VTActor for Performer<'a, F> { | |||
| data: vec![], | |||
| }); | |||
| } else { | |||
| if byte == b'p' && params == vec![1000] { | |||
| self.state.tmux_cc = true; | |||
There was a problem hiding this comment.
I don't see anything that will exit this state, so as-written, this feels like it will "break" the pane when the mode is exited :-/
There was a problem hiding this comment.
I think in iTerm2 you need to manually break the state. In Wezterm I guess "press q"? I'll see where to add this.
|
|
||
| /// Force DCS pass through for tmux cc | ||
| pub fn force_dcs_passthrough(&mut self, bytes: &[u8], actor: &mut dyn VTActor) { | ||
| for b in bytes { |
There was a problem hiding this comment.
Is there a way to batch pass through the entire buffer? That would help the performance a lot.
|
|
||
| /// Force DCS pass through for tmux cc | ||
| pub fn force_dcs_passthrough(&mut self, bytes: &[u8], actor: &mut dyn VTActor) { | ||
| for b in bytes { |
There was a problem hiding this comment.
Ah, this bit is in vtparse. Layering wise this makes things very difficult. I'd suggest doing this rerouting in the termwiz crate where we have the higher level state instead of here
There was a problem hiding this comment.
Understood. I'll try to think of something else. By the way I have an experimental branch tmux-cc at https://github.com/skyline75489/wezterm/tree/dev/tmux-cc-prototype, which handles the output part, very roughly but works. Take a look if you want :)
(bear with all my amateur Rust code)
| self.state_machine.parse(bytes, &mut perform); | ||
|
|
||
| if perform.state.tmux_cc { | ||
| self.state_machine.force_dcs_passthrough(bytes, &mut perform); |
There was a problem hiding this comment.
I haven't looked to make sure this suggestion is good, but I think that we could add DeviceControlMode::Bytes(Vec<u8>) and pass that bytes through at the termwiz layer rather than having this special state cut across to the vtparse layer.
For that to work, I think we need a bit more state for tmux in here, so that we can match for a sequence like \n%exit to break out of tmux-cc mode.
When in tmux-cc mode, we can simply bypass the vtparse parser and redirect straight through to DeviceControlMode::Bytes which would get handled in the same way as DeviceControlMode::Data, but with the advantage that it's a bit more efficient to pass the vec through there, rather than the individual Data items.
|
Closed in favor of #1090 |
The thing about tmux-cc is that the pane-output actually contains escape sequences.
See: https://github.com/tmux/tmux/wiki/Control-Mode#pane-output
When the app is in tmux-cc mode, all characters received must be passed through the the DCS handler. The tmux-cc mode can only be terminated by "a %exit line and a corresponding ST (\033) sequence"