-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't lowercase small words #6
Comments
Well that's embarrassing, thanks for the bug report. Can't believe I don't have a test case for that, despite the behaviour being mentioned in the README. The code looks like it's trying to do it: Lines 115 to 116 in 9366767
But I suspect the Line 81 in 9366767
|
On Tue Aug 30, 2022 at 1:20 AM CEST, Wesley Moore wrote:
Well that's embarrassing, thanks for the bug report. Can't believe I don't have a test case for that, despite the behaviour being mentioned in the README. The code looks like it's trying to do it:
https://github.com/wezm/titlecase/blob/93667678ed18f2b8b4762cfa838070bb014d391c/src/lib.rs#L115-L116
But I suspect the `\A` and `\z` in `SMALL_RE` are not right.
Having tried to do it by myself, I suspect you need lookbehind/lookahead
constraints if you want to do it with regexp, which Rust don't have.
So, a manual scanner may be needed.
|
Published v2.1.0 with a fix for this. |
On Tue Aug 30, 2022 at 2:22 PM CEST, Wesley Moore wrote:
Published v2.1.0 with a fix for this.
Thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example
The text was updated successfully, but these errors were encountered: