Avoid error when an input contains non-ASCII (1-byte) characters #11
Conversation
|
Do you have a test case that causes a panic? The slice is guarded by the call to |
|
@wezm Please try to pass 'μ' as the input. Or any other greek letters ('π'). By the way, is there an option to convert only the Latin alphabet? |
src/lib.rs
Outdated
| @@ -117,7 +117,7 @@ fn process_word(word: &str) -> Cow<'_, str> { | |||
| if SMALL_RE.is_match(&lower_word) { | |||
| Cow::from(lower_word) | |||
| } else if starts_with_bracket(word) { | |||
| let rest = titlecase(&word[1..]); | |||
| let rest = titlecase(&word.chars().skip(1).collect::<String>()); | |||
There was a problem hiding this comment.
The slice in this case is guarded by starts_with_bracket so it can't cause a panic because we only get in here if the first character is (.
src/lib.rs
Outdated
| @@ -157,7 +157,7 @@ fn has_internal_caps(word: &str) -> bool { | |||
| } | |||
|
|
|||
| fn has_internal_slashes(word: &str) -> bool { | |||
| !word.is_empty() && word[1..].contains('/') | |||
| !word.is_empty() && word.chars().skip(1).collect::<String>().contains('/') | |||
There was a problem hiding this comment.
This one is the source of the panic. There's no need to allocate a string though, we can iterate over the characters and check if one is a slash.
Something like:
fn has_internal_slashes(word: &str) -> bool {
word.chars().skip(1).any(|chr| chr == '/')
}
Do you mean something like passing in "μs" and have it come out as "us"? If so, that's probably out of scope for this library but there are others that could do it. I've used deunicode in another project. |
|
@wezm I mean I want to leave small greek letters as are when they are used as special mathematical operators or constants:
|
Ahh interesting. I see that it's upper-casing the greek letters too. I can see why you'd want to avoid that. I think it would be fairly easy to support a mode where only ASCII characters were upper-cased. |
|
@wezm Thank you for reviewing and merging my request. Will look forward to the updated crate soon! |
|
v2.2.1 has been published now. |
When an input contains non-ASCII (1-byte) characters, slicing &str by 1 violates the character boundaries and causes panic.