Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace joinery dependency with collect() + join() #19

Closed
wants to merge 2 commits into from
Closed

Replace joinery dependency with collect() + join() #19

wants to merge 2 commits into from

Conversation

negezor
Copy link
Contributor

@negezor negezor commented Mar 31, 2024

Instead of using external dependency one in the simple case. We can just use collect() + join(). According to performance tests, the loss in the worst case is twofold compared to itertools::join()

@wezm
Copy link
Owner

wezm commented Mar 31, 2024

Merged 056446a

@wezm wezm closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants