Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scrape archwings and companions from wikia #506

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

SlayerOrnstein
Copy link
Member

What did you fix?

Doesn't fix anything just lets scarper pull information about archwings and companions. Not sure how to do everything in js so I only used the bare minimum for companions. As Archwings share a lot of information from warframes I used the same transformer.

Considerations

  • Does this contain a new dependency? Yes
  • Does this introduce opinionated data formatting or manual data entry? Yes
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? Yes
  • Have I run the linter? Yes
  • Is is a bug fix, feature request, or enhancement? Feature

Copy link
Member

@TobiTenno TobiTenno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much cleaner this way 👍

@TobiTenno TobiTenno changed the title feat: add the ability to scrape archwings and companions from wikia feat: scrape archwings and companions from wikia Jan 8, 2024
@TobiTenno TobiTenno merged commit bc15c4c into WFCD:master Jan 8, 2024
8 checks passed
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.1261.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants