Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corufell incorrect weapon type #554

Merged

Conversation

CraigEge
Copy link
Contributor

@CraigEge CraigEge commented Apr 14, 2024

What did you fix?

Corufell has a uniqueName of /Lotus/Weapons/Tenno/Archwing/Melee/ExaltedArchScythe/ExaltedAWScytheWeapon and as such, is parsed as an Arch-Melee when it is actually a Melee.

This PR adds an override specifically for this weapon to have the correct category and type.


Reproduction steps


Evidence/screenshot/link to line

Considerations

  • Does this contain a new dependency? [No]
  • Does this introduce opinionated data formatting or manual data entry? [Yes]
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [No]
  • Have I run the linter? [Yes]
  • Is is a bug fix, feature request, or enhancement? [Bug Fix]

@CraigEge CraigEge requested a review from a team as a code owner April 14, 2024 16:58
@SlayerOrnstein SlayerOrnstein merged commit 2ffb80a into WFCD:master Apr 14, 2024
6 checks passed
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.1262.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants