Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for building Windows installer #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RalfG
Copy link
Contributor

@RalfG RalfG commented Oct 20, 2023

This PR partially addresses #101:

  • pyinstaller.spec instructs PyInstaller to freeze mokapot with all its dependencies (including Python) in an executable.
  • innosetup.iss instructs InnoSetup to bundle everything in a Windows Installer exe.
  • I extended .github/workflows/publish.yml to go through the above two steps and upload the exe as an asset to the release.

What is still needed to fully implement #101:

  • Run PyInstaller on macOS
  • Find a way to bundle the frozen package into a macOS installer
  • Run PyInstaller on Linux (not sure which distros are needed?)
  • Find a way to bundle the frozen package into a Linux installer for each distro

I don't have any experience with these open issues, so I leave them open for someone else to tackle.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #111 (1cc33b2) into main (6725bdc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files          19       19           
  Lines        1640     1640           
=======================================
  Hits         1400     1400           
  Misses        240      240           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jspaezp jspaezp self-requested a review October 28, 2023 00:40
@jspaezp jspaezp self-assigned this Oct 28, 2023
@jspaezp jspaezp mentioned this pull request Oct 28, 2023
@jspaezp
Copy link
Collaborator

jspaezp commented Oct 28, 2023

Hey there!

IMO linux and mac don't really need an installer, distributing the executable has been good enough in my experience.
I am fixing the actions to allow t his to go though and will check on the mac side of things.

@jspaezp
Copy link
Collaborator

jspaezp commented Oct 31, 2023

https://github.com/jspaezp/mokapot/actions/runs/6710019031/job/18234321059
My local branch fails due to a relative import ... I think we might need to modify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants